Add support for preferred arch symlinks

Add a symlink_preferred_arch property to binaries to allow compiling the
binary for multiple architectures and then creating a symlink to the
preferred archicture, for example dalvikvm32 and dalvikvm64, with
dalvikvm symlinked to dalvikvm64.

Test: mmma -j art/dalvikvm
Change-Id: Ied15f2be9d52c01006fe8ac207c175b78558eab1
This commit is contained in:
Colin Cross
2016-08-24 15:25:47 -07:00
parent 0f4e0d6c5d
commit 1e7d3706d6
5 changed files with 41 additions and 2 deletions

View File

@@ -34,6 +34,9 @@ type BinaryLinkerProperties struct {
// if set, add an extra objcopy --prefix-symbols= step
Prefix_symbols string
// if set, install a symlink to the preferred architecture
Symlink_preferred_arch bool
}
func init() {
@@ -59,6 +62,7 @@ func binaryHostFactory() (blueprint.Module, []interface{}) {
type binaryDecorator struct {
*baseLinker
*baseInstaller
stripper
Properties BinaryLinkerProperties
@@ -137,11 +141,12 @@ func (binary *binaryDecorator) isDependencyRoot() bool {
func NewBinary(hod android.HostOrDeviceSupported) (*Module, *binaryDecorator) {
module := newModule(hod, android.MultilibFirst)
binary := &binaryDecorator{
baseLinker: NewBaseLinker(),
baseLinker: NewBaseLinker(),
baseInstaller: NewBaseInstaller("bin", "", InstallInSystem),
}
module.compiler = NewBaseCompiler()
module.linker = binary
module.installer = NewBaseInstaller("bin", "", InstallInSystem)
module.installer = binary
return module, binary
}
@@ -158,6 +163,22 @@ func (binary *binaryDecorator) linkerInit(ctx BaseModuleContext) {
binary.Properties.Static_executable = nil
}
}
if binary.Properties.Symlink_preferred_arch {
if binary.Properties.Stem == "" && binary.Properties.Suffix == "" {
ctx.PropertyErrorf("symlink_preferred_arch", "must also specify stem or suffix")
}
var prefer bool
if ctx.Host() {
prefer = ctx.AConfig().HostPrefer32BitExecutables()
} else {
prefer = ctx.AConfig().DevicePrefer32BitExecutables()
}
if ctx.PrimaryArch() != prefer {
binary.baseInstaller.Properties.Symlinks = append(binary.baseInstaller.Properties.Symlinks,
ctx.ModuleName())
}
}
}
func (binary *binaryDecorator) static() bool {