diff --git a/bp2build/build_conversion.go b/bp2build/build_conversion.go index 415becb84..242ea1e69 100644 --- a/bp2build/build_conversion.go +++ b/bp2build/build_conversion.go @@ -320,7 +320,8 @@ func GenerateBazelTargets(ctx *CodegenContext, generateFilegroups bool) (convers // Handle modules with unconverted deps. By default, emit a warning. if unconvertedDeps := aModule.GetUnconvertedBp2buildDeps(); len(unconvertedDeps) > 0 { - msg := fmt.Sprintf("%q depends on unconverted modules: %s", m.Name(), strings.Join(unconvertedDeps, ", ")) + msg := fmt.Sprintf("%s %s:%s depends on unconverted modules: %s", + moduleType, bpCtx.ModuleDir(m), m.Name(), strings.Join(unconvertedDeps, ", ")) if ctx.unconvertedDepMode == warnUnconvertedDeps { metrics.moduleWithUnconvertedDepsMsgs = append(metrics.moduleWithUnconvertedDepsMsgs, msg) } else if ctx.unconvertedDepMode == errorModulesUnconvertedDeps { @@ -329,7 +330,8 @@ func GenerateBazelTargets(ctx *CodegenContext, generateFilegroups bool) (convers } } if unconvertedDeps := aModule.GetMissingBp2buildDeps(); len(unconvertedDeps) > 0 { - msg := fmt.Sprintf("%q depends on missing modules: %s", m.Name(), strings.Join(unconvertedDeps, ", ")) + msg := fmt.Sprintf("%s %s:%s depends on missing modules: %s", + moduleType, bpCtx.ModuleDir(m), m.Name(), strings.Join(unconvertedDeps, ", ")) if ctx.unconvertedDepMode == warnUnconvertedDeps { metrics.moduleWithMissingDepsMsgs = append(metrics.moduleWithMissingDepsMsgs, msg) } else if ctx.unconvertedDepMode == errorModulesUnconvertedDeps { diff --git a/bp2build/build_conversion_test.go b/bp2build/build_conversion_test.go index d36d2a90a..c5644ed2d 100644 --- a/bp2build/build_conversion_test.go +++ b/bp2build/build_conversion_test.go @@ -1032,7 +1032,7 @@ func TestModuleTypeBp2Build(t *testing.T) { ], bazel_module: { bp2build_available: true }, }`, - ExpectedErr: fmt.Errorf(`"foobar" depends on unconverted modules: foo`), + ExpectedErr: fmt.Errorf(`filegroup .:foobar depends on unconverted modules: foo`), Filesystem: map[string]string{ "other/Android.bp": `filegroup { name: "foo",