StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correctly set date and mode fields for MANIFEST.MF

Browse Source 
The file header returned by jar.ManifestFileContents had unset
date and mode fields.  The unset date field resulted in the
"Last Mod Time" field in the zip file being set to 0, which
OpenJDK 9's jar implementation treats as an error:
java.time.DateTimeException: Invalid value for MonthOfYear (valid values 1 - 12): 0

Bug: 67095392
Test: zipdetails out/host/linux-x86/framework/tradefed.jar
Change-Id: I0a818d57420f5e5de57e8ff57791951c1b538443
This commit is contained in:
Colin Cross
2017-09-29 13:57:10 -07:00
parent 86a63ff366
commit 2825cb3f8d
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
jar/jar.go
View File

@@ -94,6 +94,8 @@ func ManifestFileContents(src string) (*zip.FileHeader, []byte, error) {
Method: zip.Store, Method: zip.Store,
UncompressedSize64: uint64(len(b)), UncompressedSize64: uint64(len(b)),
} }
fh.SetMode(0700)
fh.SetModTime(DefaultTime)
return fh, b, nil return fh, b, nil
} }