StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Process bazel metrics prior to potentially exiting upload.go"

Browse Source
This commit is contained in:
Mark Dacek
2023-05-03 03:37:38 +00:00
committed by Gerrit Code Review
parent 833d7ee6e3 ed2253e8df
commit 2953486e31
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ui/build/upload.go
View File

@@ -138,6 +138,9 @@ func parsePhaseTiming(line string) bazel_metrics_proto.PhaseTiming {
return phaseTiming return phaseTiming
} }
// This method takes a file created by bazel's --analyze-profile mode and
// writes bazel metrics data to the provided filepath.
// TODO(b/279987768) - move this outside of upload.go
func processBazelMetrics(bazelProfileFile string, bazelMetricsFile string, ctx Context) { func processBazelMetrics(bazelProfileFile string, bazelMetricsFile string, ctx Context) {
if bazelProfileFile == "" { if bazelProfileFile == "" {
return return
@@ -189,12 +192,13 @@ func UploadMetrics(ctx Context, config Config, simpleOutput bool, buildStarted t
defer ctx.EndTrace() defer ctx.EndTrace()
uploader := config.MetricsUploaderApp() uploader := config.MetricsUploaderApp()
processBazelMetrics(bazelProfileFile, bazelMetricsFile, ctx)
if uploader == "" { if uploader == "" {
// If the uploader path was not specified, no metrics shall be uploaded. // If the uploader path was not specified, no metrics shall be uploaded.
return return
} }
processBazelMetrics(bazelProfileFile, bazelMetricsFile, ctx)
// Several of the files might be directories. // Several of the files might be directories.
metricsFiles := pruneMetricsFiles(paths) metricsFiles := pruneMetricsFiles(paths)
if len(metricsFiles) == 0 { if len(metricsFiles) == 0 {