From 29f5576357b3627a2a7bf7eada40cd6152fa63b5 Mon Sep 17 00:00:00 2001 From: Paul Duffin Date: Tue, 21 Jan 2020 18:20:43 +0000 Subject: [PATCH] Remove unused java_sdk_library_import properties The properties are just passed through to the java_import module that it creates to import the stubs so could be used if set. However, none of the current usages of java_sdk_library_import actually set them and it is not clear why the following would ever be set on java_sdk_library_import: * installable * exclude_files * exclude_dirs The above properties look as though they were simply copied from the ImportProperties struct. The libs property is also unused but it seems as though it should be used to improve compatibility with the source module. e.g. the source module for android.test.runner has android.test.base and android.test.mock in its libs. However, the prebuilt version of it does not. Bug: 148080325 Test: m nothing Change-Id: I710e3962b2e34b2b0cc81685d07d4948cef4e6ad --- java/sdk_library.go | 8 -------- 1 file changed, 8 deletions(-) diff --git a/java/sdk_library.go b/java/sdk_library.go index 9b30e2ca4..72c4a7c63 100644 --- a/java/sdk_library.go +++ b/java/sdk_library.go @@ -838,16 +838,8 @@ type sdkLibraryImportProperties struct { Sdk_version *string - Installable *bool - // List of shared java libs that this module has dependencies to Libs []string - - // List of files to remove from the jar file(s) - Exclude_files []string - - // List of directories to remove from the jar file(s) - Exclude_dirs []string } type sdkLibraryImport struct {