Don't create a new module for bp2build conversion.
A performance improvement for bp2build as Blueprint/Soong no longer have the overhead of additional modules. The creation of these modules results in: * traversal of additional modules for each subsequent mutator * synchronization over a go channel to collect newly created modules: https://cs.android.com/android/platform/superproject/+/master:build/blueprint/context.go;l=2594,2600;drc=1602226f23181b8c3fbfcaf3358f0297e839d7d3 We avoid both of these by storing the information directly in the underlying module. Also as a fringe benefit, removes some necessary boilerplate for conversion. For benchmarks, reduces runtime ~1% for 1% converted, ~24% for 100% converted. See more: go/benchmarks-for-https:-r.android.com-1792714 Test: ran benchmarks/tests in bp2build Test: build/bazel/ci/bp2build.sh Change-Id: Ie9273b8cbab5bc6edac1728067ce184382feb211
This commit is contained in:
@@ -527,18 +527,6 @@ type bazelShBinaryAttributes struct {
|
||||
// visibility
|
||||
}
|
||||
|
||||
type bazelShBinary struct {
|
||||
android.BazelTargetModuleBase
|
||||
bazelShBinaryAttributes
|
||||
}
|
||||
|
||||
func BazelShBinaryFactory() android.Module {
|
||||
module := &bazelShBinary{}
|
||||
module.AddProperties(&module.bazelShBinaryAttributes)
|
||||
android.InitBazelTargetModule(module)
|
||||
return module
|
||||
}
|
||||
|
||||
func ShBinaryBp2Build(ctx android.TopDownMutatorContext) {
|
||||
m, ok := ctx.Module().(*ShBinary)
|
||||
if !ok || !m.ConvertWithBp2build(ctx) {
|
||||
@@ -556,13 +544,7 @@ func ShBinaryBp2Build(ctx android.TopDownMutatorContext) {
|
||||
Rule_class: "sh_binary",
|
||||
}
|
||||
|
||||
ctx.CreateBazelTargetModule(BazelShBinaryFactory, m.Name(), props, attrs)
|
||||
ctx.CreateBazelTargetModule(m.Name(), props, attrs)
|
||||
}
|
||||
|
||||
func (m *bazelShBinary) Name() string {
|
||||
return m.BaseModuleName()
|
||||
}
|
||||
|
||||
func (m *bazelShBinary) GenerateAndroidBuildActions(ctx android.ModuleContext) {}
|
||||
|
||||
var Bool = proptools.Bool
|
||||
|
Reference in New Issue
Block a user