Apply pylint to remaining scripts in hiddenapi
1. Run pyformat scripts/hiddenapi -s 4 --force_quote_type none -i to fix formatting. 2. rename restricted variable names (e.g. variable name "input" has been changed to "csvfile") 3. use pylint: disable=<X> where fixes are not obvious Test: m merge_csv signature_patterns signature_patterns_test Test: pylint --rcfile tools/repohooks/tools/pylintrc <file1> <file1_test> Bug: 195738175 Change-Id: I800a208f9c0ee1d32e68e4b20fd5933b3ab92c0e
This commit is contained in:
@@ -18,21 +18,25 @@
|
||||
import io
|
||||
import unittest
|
||||
|
||||
from signature_patterns import *
|
||||
from signature_patterns import * #pylint: disable=unused-wildcard-import,wildcard-import
|
||||
|
||||
|
||||
class TestGeneratedPatterns(unittest.TestCase):
|
||||
|
||||
def produce_patterns_from_string(self, csv):
|
||||
with io.StringIO(csv) as f:
|
||||
def produce_patterns_from_string(self, csvdata):
|
||||
with io.StringIO(csvdata) as f:
|
||||
return produce_patterns_from_stream(f)
|
||||
|
||||
def test_generate(self):
|
||||
patterns = self.produce_patterns_from_string('''
|
||||
#pylint: disable=line-too-long
|
||||
patterns = self.produce_patterns_from_string(
|
||||
'''
|
||||
Ljava/lang/ProcessBuilder$Redirect$1;-><init>()V,blocked
|
||||
Ljava/lang/Character$UnicodeScript;->of(I)Ljava/lang/Character$UnicodeScript;,public-api
|
||||
Ljava/lang/Object;->hashCode()I,public-api,system-api,test-api
|
||||
Ljava/lang/Object;->toString()Ljava/lang/String;,blocked
|
||||
''')
|
||||
'''
|
||||
)
|
||||
#pylint: enable=line-too-long
|
||||
expected = [
|
||||
"java/lang/Character",
|
||||
"java/lang/Object",
|
||||
@@ -40,5 +44,6 @@ Ljava/lang/Object;->toString()Ljava/lang/String;,blocked
|
||||
]
|
||||
self.assertEqual(expected, patterns)
|
||||
|
||||
|
||||
if __name__ == '__main__':
|
||||
unittest.main(verbosity=2)
|
||||
|
Reference in New Issue
Block a user