StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Remove SdkMemberType.FinalizeModule"

Browse Source
This commit is contained in:
Paul Duffin
2020-03-16 11:04:26 +00:00
committed by Gerrit Code Review
parent 5417f775e5 0174d8d2c9
commit 2c73260636
4 changed files with 28 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
android/sdk.go
View File

@@ -356,15 +356,8 @@ type SdkMemberType interface {
// structure and calls AddToPropertySet(...) on the properties struct to add the member
// specific properties in the correct place in the structure.
//
// * Finally, the FinalizeModule(...) method is called to add any additional properties.
// This was created to allow the property ordering in existing tests to be maintained so
// as to avoid having to change tests while refactoring.
//
AddPrebuiltModule(sdkModuleContext ModuleContext, builder SnapshotBuilder, member SdkMember) BpModule
// Add any additional properties to the end of the module.
FinalizeModule(sdkModuleContext ModuleContext, builder SnapshotBuilder, member SdkMember, bpModule BpModule)
// Create a structure into which variant specific properties can be added.
CreateVariantPropertiesStruct() SdkMemberProperties
}
@@ -397,10 +390,6 @@ func (b *SdkMemberTypeBase) AddPrebuiltModule(sdkModuleContext ModuleContext, bu
return nil
}
func (b *SdkMemberTypeBase) FinalizeModule(sdkModuleContext ModuleContext, builder SnapshotBuilder, member SdkMember, module BpModule) {
// Do nothing by default
}
func (b *SdkMemberTypeBase) CreateVariantPropertiesStruct() SdkMemberProperties {
panic("override me")
}