From 2f15bae3369f6abbe1a8112bb294b62a45709ee3 Mon Sep 17 00:00:00 2001 From: Ivan Lozano Date: Thu, 9 Apr 2020 09:32:15 -0400 Subject: [PATCH] Clean up rust tests. The list of required deps for testing is a lot shorter as we no longer include as many prebuilt libraries and our list of stdlibs is much shorter. Remove the libraries we no longer need, and add the non-prebuilt libstd and libtest to the deps generated for every test. Bug: 153463188 Test: Soong tests pass. Change-Id: I94f7b514797ab8d6aedb543ea6afdb07611b7293 --- rust/rust_test.go | 19 -------------- rust/testing.go | 65 ++++++++++++++++++----------------------------- 2 files changed, 25 insertions(+), 59 deletions(-) diff --git a/rust/rust_test.go b/rust/rust_test.go index 020581dfc..02b190f0f 100644 --- a/rust/rust_test.go +++ b/rust/rust_test.go @@ -215,25 +215,6 @@ func TestProcMacroDeviceDeps(t *testing.T) { srcs: ["foo.rs"], crate_name: "bar", } - // Make a dummy libstd to let resolution go through - rust_library_dylib { - name: "libstd", - crate_name: "std", - srcs: ["foo.rs"], - no_stdlibs: true, - } - rust_library_dylib { - name: "libterm", - crate_name: "term", - srcs: ["foo.rs"], - no_stdlibs: true, - } - rust_library_dylib { - name: "libtest", - crate_name: "test", - srcs: ["foo.rs"], - no_stdlibs: true, - } rust_proc_macro { name: "libpm", rlibs: ["libbar"], diff --git a/rust/testing.go b/rust/testing.go index f9adec828..c3a462553 100644 --- a/rust/testing.go +++ b/rust/testing.go @@ -21,51 +21,11 @@ import ( func GatherRequiredDepsForTest() string { bp := ` - rust_prebuilt_dylib { - name: "libarena_x86_64-unknown-linux-gnu", - srcs: [""], - host_supported: true, - } - rust_prebuilt_dylib { - name: "libfmt_macros_x86_64-unknown-linux-gnu", - srcs: [""], - host_supported: true, - } - rust_prebuilt_dylib { - name: "libgraphviz_x86_64-unknown-linux-gnu", - srcs: [""], - host_supported: true, - } - rust_prebuilt_dylib { - name: "libserialize_x86_64-unknown-linux-gnu", - srcs: [""], - host_supported: true, - } rust_prebuilt_dylib { name: "libstd_x86_64-unknown-linux-gnu", srcs: [""], host_supported: true, } - rust_prebuilt_dylib { - name: "libsyntax_x86_64-unknown-linux-gnu", - srcs: [""], - host_supported: true, - } - rust_prebuilt_dylib { - name: "libsyntax_ext_x86_64-unknown-linux-gnu", - srcs: [""], - host_supported: true, - } - rust_prebuilt_dylib { - name: "libsyntax_pos_x86_64-unknown-linux-gnu", - srcs: [""], - host_supported: true, - } - rust_prebuilt_dylib { - name: "libterm_x86_64-unknown-linux-gnu", - srcs: [""], - host_supported: true, - } rust_prebuilt_dylib { name: "libtest_x86_64-unknown-linux-gnu", srcs: [""], @@ -81,6 +41,31 @@ func GatherRequiredDepsForTest() string { nocrt: true, system_shared_libs: [], } + rust_library_dylib { + name: "libstd", + crate_name: "std", + srcs: ["foo.rs"], + no_stdlibs: true, + } + rust_library_rlib { + name: "libstd.static", + crate_name: "std", + srcs: ["foo.rs"], + no_stdlibs: true, + } + rust_library_dylib { + name: "libtest", + crate_name: "test", + srcs: ["foo.rs"], + no_stdlibs: true, + } + rust_library_rlib { + name: "libtest.static", + crate_name: "test", + srcs: ["foo.rs"], + no_stdlibs: true, + } + ` + cc.GatherRequiredDepsForTest(android.NoOsType) return bp }