From 1001a7971a298f83ed833d5df151c5f5694912e8 Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Thu, 21 Mar 2019 22:21:39 -0700 Subject: [PATCH] Rename jetifier property and add it to androidmk Rename jetifier_enabled to jetifier since there are no users yet and it is more consistent with the rest of the Soong properties. Also add it to androidmk translation. Fixes: 123524520 Test: androidmk_test.go Change-Id: Ib4c688cf3cb171a822ddf7dd49467522c4c1276c --- androidmk/cmd/androidmk/android.go | 1 + androidmk/cmd/androidmk/androidmk_test.go | 2 ++ java/aar.go | 4 ++-- java/java.go | 4 ++-- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/androidmk/cmd/androidmk/android.go b/androidmk/cmd/androidmk/android.go index 9276eb5fd..52bcf9c99 100644 --- a/androidmk/cmd/androidmk/android.go +++ b/androidmk/cmd/androidmk/android.go @@ -201,6 +201,7 @@ func init() { "LOCAL_DEX_PREOPT_GENERATE_PROFILE": "dex_preopt.profile_guided", "LOCAL_PRIVATE_PLATFORM_APIS": "platform_apis", + "LOCAL_JETIFIER_ENABLED": "jetifier", }) } diff --git a/androidmk/cmd/androidmk/androidmk_test.go b/androidmk/cmd/androidmk/androidmk_test.go index b2c3fabb6..f2dc6ff21 100644 --- a/androidmk/cmd/androidmk/androidmk_test.go +++ b/androidmk/cmd/androidmk/androidmk_test.go @@ -631,12 +631,14 @@ include $(call all-makefiles-under,$(LOCAL_PATH)) LOCAL_SRC_FILES := test.jar LOCAL_MODULE_CLASS := JAVA_LIBRARIES LOCAL_STATIC_ANDROID_LIBRARIES := + LOCAL_JETIFIER_ENABLED := true include $(BUILD_PREBUILT) `, expected: ` java_import { jars: ["test.jar"], + jetifier: true, } `, }, diff --git a/java/aar.go b/java/aar.go index ba9e1873f..a993bf6a9 100644 --- a/java/aar.go +++ b/java/aar.go @@ -446,7 +446,7 @@ type AARImportProperties struct { Libs []string // if set to true, run Jetifier against .aar file. Defaults to false. - Jetifier_enabled *bool + Jetifier *bool } type AARImport struct { @@ -540,7 +540,7 @@ func (a *AARImport) GenerateAndroidBuildActions(ctx android.ModuleContext) { aarName := ctx.ModuleName() + ".aar" var aar android.Path aar = android.PathForModuleSrc(ctx, a.properties.Aars[0]) - if Bool(a.properties.Jetifier_enabled) { + if Bool(a.properties.Jetifier) { inputFile := aar aar = android.PathForModuleOut(ctx, "jetifier", aarName) TransformJetifier(ctx, aar.(android.WritablePath), inputFile) diff --git a/java/java.go b/java/java.go index 3eae93294..1fd0a9e31 100644 --- a/java/java.go +++ b/java/java.go @@ -1726,7 +1726,7 @@ type ImportProperties struct { Exclude_dirs []string // if set to true, run Jetifier against .jar file. Defaults to false. - Jetifier_enabled *bool + Jetifier *bool } type Import struct { @@ -1771,7 +1771,7 @@ func (j *Import) GenerateAndroidBuildActions(ctx android.ModuleContext) { outputFile := android.PathForModuleOut(ctx, "combined", jarName) TransformJarsToJar(ctx, outputFile, "for prebuilts", jars, android.OptionalPath{}, false, j.properties.Exclude_files, j.properties.Exclude_dirs) - if Bool(j.properties.Jetifier_enabled) { + if Bool(j.properties.Jetifier) { inputFile := outputFile outputFile = android.PathForModuleOut(ctx, "jetifier", jarName) TransformJetifier(ctx, outputFile, inputFile)