diff --git a/android/config.go b/android/config.go index ca376dbf6..25615b6d9 100644 --- a/android/config.go +++ b/android/config.go @@ -198,6 +198,14 @@ func saveToConfigFile(config jsonConfigurable, filename string) error { // TestConfig returns a Config object suitable for using for tests func TestConfig(buildDir string, env map[string]string) Config { + envCopy := make(map[string]string) + for k, v := range env { + envCopy[k] = v + } + + // Copy the real PATH value to the test environment, it's needed by HostSystemTool() used in x86_darwin_host.go + envCopy["PATH"] = originalEnv["PATH"] + config := &config{ productVariables: productVariables{ DeviceName: stringPtr("test_device"), @@ -212,7 +220,7 @@ func TestConfig(buildDir string, env map[string]string) Config { buildDir: buildDir, captureBuild: true, - env: env, + env: envCopy, } config.deviceConfig = &deviceConfig{ config: config, diff --git a/cc/proto_test.go b/cc/proto_test.go index a7fcef935..4f0de7801 100644 --- a/cc/proto_test.go +++ b/cc/proto_test.go @@ -15,7 +15,6 @@ package cc import ( - "runtime" "strings" "testing" @@ -38,9 +37,6 @@ func TestProto(t *testing.T) { }) t.Run("plugin", func(t *testing.T) { - if runtime.GOOS != "linux" { - t.Skip("TODO(b/129763458): cc_binary_host tests fail on mac when trying to exec xcrun") - } ctx := testCc(t, ` cc_binary_host { name: "protoc-gen-foobar",