diff --git a/mk2rbc/mk2rbc.go b/mk2rbc/mk2rbc.go index b9d78a6c8..14988e734 100644 --- a/mk2rbc/mk2rbc.go +++ b/mk2rbc/mk2rbc.go @@ -91,9 +91,9 @@ var knownFunctions = map[string]interface { "foreach": &foreachCallPaser{}, "if": &ifCallParser{}, "info": &makeControlFuncParser{name: baseName + ".mkinfo"}, - "is-board-platform": &isBoardPlatformCallParser{}, + "is-board-platform": &simpleCallParser{name: baseName + ".board_platform_is", returnType: starlarkTypeBool, addGlobals: true}, "is-board-platform2": &simpleCallParser{name: baseName + ".board_platform_is", returnType: starlarkTypeBool, addGlobals: true}, - "is-board-platform-in-list": &isBoardPlatformInListCallParser{}, + "is-board-platform-in-list": &simpleCallParser{name: baseName + ".board_platform_in", returnType: starlarkTypeBool, addGlobals: true}, "is-board-platform-in-list2": &simpleCallParser{name: baseName + ".board_platform_in", returnType: starlarkTypeBool, addGlobals: true}, "is-product-in-list": &isProductInListCallParser{}, "is-vendor-board-platform": &isVendorBoardPlatformCallParser{}, @@ -1439,32 +1439,6 @@ func (p *myDirCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkp return &variableRefExpr{ctx.addVariable("LOCAL_PATH"), true} } -type isBoardPlatformCallParser struct{} - -func (p *isBoardPlatformCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr { - if args.Empty() { - return ctx.newBadExpr(node, "is-board-platform requires an argument") - } - return &eqExpr{ - left: &variableRefExpr{ctx.addVariable("TARGET_BOARD_PLATFORM"), false}, - right: ctx.parseMakeString(node, args), - isEq: true, - } -} - -type isBoardPlatformInListCallParser struct{} - -func (p *isBoardPlatformInListCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr { - if args.Empty() { - return ctx.newBadExpr(node, "is-board-platform-in-list requires an argument") - } - return &inExpr{ - expr: &variableRefExpr{ctx.addVariable("TARGET_BOARD_PLATFORM"), false}, - list: maybeConvertToStringList(ctx.parseMakeString(node, args)), - isNot: false, - } -} - type isProductInListCallParser struct{} func (p *isProductInListCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr { diff --git a/mk2rbc/mk2rbc_test.go b/mk2rbc/mk2rbc_test.go index 2d44d42d9..ec6dfd0a6 100644 --- a/mk2rbc/mk2rbc_test.go +++ b/mk2rbc/mk2rbc_test.go @@ -598,9 +598,9 @@ endif def init(g, handle): cfg = rblf.cfg(handle) - if g.get("TARGET_BOARD_PLATFORM", "") in ["msm8998"]: + if rblf.board_platform_in(g, "msm8998"): pass - elif g.get("TARGET_BOARD_PLATFORM", "") != "copper": + elif not rblf.board_platform_is(g, "copper"): pass elif g.get("TARGET_BOARD_PLATFORM", "") not in g["QCOM_BOARD_PLATFORMS"]: pass