StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Downgrade/disable lint checks

Browse Source 
Lint is being updated, and some of the
new checks have many failures or false
positives in the current android tree.

Bug: 215567981
Bug: 238784089
Test: Presubmits
Change-Id: I33a47d3c0404ca37f0334421a02bb80f745ae792
This commit is contained in:
Cole Faust
2022-06-29 14:58:03 -07:00
parent 7631bdf109
commit 3f6462693e
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/lint.go
View File

@@ -338,6 +338,14 @@ func (l *linter) lint(ctx android.ModuleContext) {
ctx.PropertyErrorf("lint.disabled_checks", ctx.PropertyErrorf("lint.disabled_checks",
"Can't disable %v checks if min_sdk_version is different from sdk_version.", filtered) "Can't disable %v checks if min_sdk_version is different from sdk_version.", filtered)
} }
// TODO(b/238784089): Remove this workaround when the NewApi issues have been addressed in PermissionController
if ctx.ModuleName() == "PermissionController" {
l.extraMainlineLintErrors = android.FilterListPred(l.extraMainlineLintErrors, func(s string) bool {
return s != "NewApi"
})
l.properties.Lint.Warning_checks = append(l.properties.Lint.Warning_checks, "NewApi")
}
} }
extraLintCheckModules := ctx.GetDirectDepsWithTag(extraLintCheckTag) extraLintCheckModules := ctx.GetDirectDepsWithTag(extraLintCheckTag)

5
java/lint_defaults.txt
View File

@@ -6,6 +6,7 @@
--disable_check AnimatorKeep --disable_check AnimatorKeep
--disable_check AppBundleLocaleChanges --disable_check AppBundleLocaleChanges
--disable_check AppCompatCustomView
--disable_check BlockedPrivateApi --disable_check BlockedPrivateApi
--disable_check CustomSplashScreen --disable_check CustomSplashScreen
--disable_check CustomX509TrustManager --disable_check CustomX509TrustManager
@@ -22,6 +23,7 @@
--disable_check PrivateApi --disable_check PrivateApi
--disable_check ProtectedPermissions --disable_check ProtectedPermissions
--disable_check QueryPermissionsNeeded --disable_check QueryPermissionsNeeded
--disable_check ReservedSystemPermission
--disable_check ScopedStorage --disable_check ScopedStorage
--disable_check ServiceCast --disable_check ServiceCast
--disable_check SoonBlockedPrivateApi --disable_check SoonBlockedPrivateApi
@@ -99,7 +101,10 @@
--warning_check WrongViewCast # 1 occurences in 1 modules --warning_check WrongViewCast # 1 occurences in 1 modules
--warning_check CoarseFineLocation --warning_check CoarseFineLocation
--warning_check ExtraText
--warning_check IntentFilterExportedReceiver --warning_check IntentFilterExportedReceiver
--warning_check MissingInflatedId
--warning_check NotificationPermission
--warning_check QueryAllPackagesPermission --warning_check QueryAllPackagesPermission
--warning_check RemoteViewLayout --warning_check RemoteViewLayout
--warning_check SupportAnnotationUsage --warning_check SupportAnnotationUsage