StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rust: Prevent manually defined lib link flags.

Browse Source 
Adds a filter to prevent modules from manually defining certain linkage
flags. These flags should only be automatically generated based on
listed dependencies.

Bug: 161942165
Test: Soong tests pass
Change-Id: Ibc014391ef1de10188c2d139d41d0241d6c68b5f
This commit is contained in:
Ivan Lozano
2021-07-27 12:29:12 -04:00
parent 6e4950a061
commit 45a9e3196c
2 changed files with 90 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
rust/compiler.go
View File

@@ -17,6 +17,7 @@ package rust
import (
"fmt"
"path/filepath"
"strings"
"github.com/google/blueprint/proptools"
@@ -235,6 +236,25 @@ func (compiler *baseCompiler) compilerFlags(ctx ModuleContext, flags Flags) Flag
if err != nil {
ctx.PropertyErrorf("lints", err.Error())
}
// linkage-related flags are disallowed.
for _, s := range compiler.Properties.Ld_flags {
if strings.HasPrefix(s, "-Wl,-l") || strings.HasPrefix(s, "-Wl,-L") {
ctx.PropertyErrorf("ld_flags", "'-Wl,-l' and '-Wl,-L' flags cannot be manually specified")
}
}
for _, s := range compiler.Properties.Flags {
if strings.HasPrefix(s, "-l") || strings.HasPrefix(s, "-L") {
ctx.PropertyErrorf("flags", "'-l' and '-L' flags cannot be manually specified")
}
if strings.HasPrefix(s, "--extern") {
ctx.PropertyErrorf("flags", "'--extern' flag cannot be manually specified")
}
if strings.HasPrefix(s, "-Clink-args=") || strings.HasPrefix(s, "-C link-args=") {
ctx.PropertyErrorf("flags", "'-C link-args' flag cannot be manually specified")
}
}
flags.RustFlags = append(flags.RustFlags, lintFlags)
flags.RustFlags = append(flags.RustFlags, compiler.Properties.Flags...)
flags.RustFlags = append(flags.RustFlags, compiler.cfgsToFlags()...)