diff --git a/mk2rbc/mk2rbc_test.go b/mk2rbc/mk2rbc_test.go index 46212ee8b..ca7fe6f23 100644 --- a/mk2rbc/mk2rbc_test.go +++ b/mk2rbc/mk2rbc_test.go @@ -414,7 +414,7 @@ endif def init(g, handle): cfg = rblf.cfg(handle) - if rblf.filter(g.get("PRODUCT_LIST", ""), g["TARGET_PRODUCT"]): + if rblf.filter(g.get("PRODUCT_LIST", []), g["TARGET_PRODUCT"]): pass `, }, diff --git a/mk2rbc/variable.go b/mk2rbc/variable.go index 88d63c96e..4bb9ed52d 100644 --- a/mk2rbc/variable.go +++ b/mk2rbc/variable.go @@ -299,6 +299,10 @@ func (ctx *parseContext) addVariable(name string) variable { vt = vi.valueType } } + if strings.HasSuffix(name, "_LIST") && vt == starlarkTypeUnknown { + // Heuristics: Variables with "_LIST" suffix are lists + vt = starlarkTypeList + } v = &otherGlobalVariable{baseVariable{nam: name, typ: vt}} } ctx.variables[name] = v