Add an allowlist for modules that have broken optional_uses_libs.
Bug: 282877248 Test: m nothing Change-Id: I1afe9d523af0633f0428d4c15e1417db1dae4e93
This commit is contained in:
@@ -1396,7 +1396,7 @@ func (u *usesLibrary) deps(ctx android.BottomUpMutatorContext, addCompatDeps boo
|
||||
func (u *usesLibrary) presentOptionalUsesLibs(ctx android.BaseModuleContext) []string {
|
||||
optionalUsesLibs := android.FilterListPred(u.usesLibraryProperties.Optional_uses_libs, func(s string) bool {
|
||||
exists := ctx.OtherModuleExists(s)
|
||||
if !exists {
|
||||
if !exists && !android.InList(ctx.ModuleName(), ctx.Config().BuildWarningBadOptionalUsesLibsAllowlist()) {
|
||||
fmt.Printf("Warning: Module '%s' depends on non-existing optional_uses_libs '%s'\n", ctx.ModuleName(), s)
|
||||
}
|
||||
return exists
|
||||
|
@@ -2644,6 +2644,9 @@ func TestUsesLibraries(t *testing.T) {
|
||||
prepareForJavaTest,
|
||||
PrepareForTestWithJavaSdkLibraryFiles,
|
||||
FixtureWithLastReleaseApis("runtime-library", "foo", "quuz", "qux", "bar", "fred"),
|
||||
android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
|
||||
variables.BuildWarningBadOptionalUsesLibsAllowlist = []string{"app", "prebuilt"}
|
||||
}),
|
||||
).RunTestWithBp(t, bp)
|
||||
|
||||
app := result.ModuleForTests("app", "android_common")
|
||||
|
Reference in New Issue
Block a user