StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

soong: move -Wimplicit-fallthrough from cflags to cxxflags

Browse Source 
The compiler upgrade to r370808 can now check C code for implicit
fallthrough. This is triggering a massive number of warnings throughout
external/ and the rest of the platform.

Revisit enabling this for C another day.

Bug: 139945549
Test: m
Change-Id: I8dfaedab78c6230b46e8a45a9e65106dec363380
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
This commit is contained in:
Nick Desaulniers
2019-10-30 13:55:26 -07:00
parent d0e39622c7
commit 4e31fb87af
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cc/config/clang.go
View File

@@ -101,9 +101,6 @@ func init() {
// not emit the table by default on Android since NDK still uses GNU binutils. // not emit the table by default on Android since NDK still uses GNU binutils.
"-faddrsig", "-faddrsig",
// -Wimplicit-fallthrough is not enabled by -Wall.
"-Wimplicit-fallthrough",
// Help catch common 32/64-bit errors. // Help catch common 32/64-bit errors.
"-Werror=int-conversion", "-Werror=int-conversion",
@@ -138,6 +135,9 @@ func init() {
}, " ")) }, " "))
pctx.StaticVariable("ClangExtraCppflags", strings.Join([]string{ pctx.StaticVariable("ClangExtraCppflags", strings.Join([]string{
// -Wimplicit-fallthrough is not enabled by -Wall.
"-Wimplicit-fallthrough",
// Enable clang's thread-safety annotations in libcxx. // Enable clang's thread-safety annotations in libcxx.
// Turn off -Wthread-safety-negative, to avoid breaking projects that use -Weverything. // Turn off -Wthread-safety-negative, to avoid breaking projects that use -Weverything.
"-D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS", "-D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS",