StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

soong: add __clang_analyzer__ to clang-tidy

Browse Source 
We have code that acts slightly differently when the static analyzer is
running, so that it can produce more accurate diagnostics (e.g. less
false positives). It uses __clang_analyzer__ to detect the static
analyzer.

When the static analyzer is run via clang-tidy, __clang_analyzer__
doesn't get defined.

Bug: None
Test: WITH_TIDY=1 m. clang-tidy now acts as expected in code made for
the static analyzer

Change-Id: I460ff410640524633c0a60b71d34927d17e1ed98
This commit is contained in:
George Burgess IV
2017-05-03 18:13:08 -07:00
parent 0e409a2810
commit 561a3fe4af
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cc/tidy.go
View File

@@ -77,6 +77,10 @@ func (tidy *tidyFeature) flags(ctx ModuleContext, flags Flags) Flags {
flags.TidyFlags = append(flags.TidyFlags, headerFilter) flags.TidyFlags = append(flags.TidyFlags, headerFilter)
} }
// We might be using the static analyzer through clang tidy.
// https://bugs.llvm.org/show_bug.cgi?id=32914
flags.TidyFlags = append(flags.TidyFlags, "-extra-arg-before=-D__clang_analyzer__")
tidyChecks := "-checks=" tidyChecks := "-checks="
if checks := ctx.AConfig().TidyChecks(); len(checks) > 0 { if checks := ctx.AConfig().TidyChecks(); len(checks) > 0 {
tidyChecks += checks tidyChecks += checks