StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Correct bp2build canonical_from_root logic"

Browse Source
This commit is contained in:
Liz Kammer
2022-02-15 20:43:57 +00:00
committed by Gerrit Code Review
parent b3e5b18aa2 7756c8f20e
commit 5ee913f527
5 changed files with 5 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
android/proto.go
View File

@@ -187,7 +187,7 @@ func Bp2buildProtoProperties(ctx Bp2buildMutatorContext, module Module, srcs baz
if axis == bazel.NoConfigAxis {
info.Type = props.Proto.Type
if proptools.BoolDefault(props.Proto.Canonical_path_from_root, canonicalPathFromRootDefault) {
if !proptools.BoolDefault(props.Proto.Canonical_path_from_root, canonicalPathFromRootDefault) {
// an empty string indicates to strips the package path
path := ""
attrs.Strip_import_prefix = &path

2
bp2build/cc_binary_conversion_test.go
View File

@@ -459,7 +459,6 @@ func TestCcBinarySharedProto(t *testing.T) {
name: "foo",
srcs: ["foo.proto"],
proto: {
canonical_path_from_root: false,
},
include_build_directory: false,
}`,
@@ -483,7 +482,6 @@ func TestCcBinaryStaticProto(t *testing.T) {
srcs: ["foo.proto"],
static_executable: true,
proto: {
canonical_path_from_root: false,
},
include_build_directory: false,
}`,

10
bp2build/cc_library_conversion_test.go
View File

@@ -1999,7 +1999,6 @@ func TestCcLibraryProtoSimple(t *testing.T) {
expectedBazelTargets: []string{
makeBazelTarget("proto_library", "foo_proto", attrNameToString{
"srcs": `["foo.proto"]`,
"strip_import_prefix": `""`,
}), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{
"deps": `[":foo_proto"]`,
}), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{
@@ -2025,6 +2024,7 @@ func TestCcLibraryProtoNoCanonicalPathFromRoot(t *testing.T) {
expectedBazelTargets: []string{
makeBazelTarget("proto_library", "foo_proto", attrNameToString{
"srcs": `["foo.proto"]`,
"strip_import_prefix": `""`,
}), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{
"deps": `[":foo_proto"]`,
}), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{
@@ -2050,7 +2050,6 @@ func TestCcLibraryProtoExplicitCanonicalPathFromRoot(t *testing.T) {
expectedBazelTargets: []string{
makeBazelTarget("proto_library", "foo_proto", attrNameToString{
"srcs": `["foo.proto"]`,
"strip_import_prefix": `""`,
}), makeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", attrNameToString{
"deps": `[":foo_proto"]`,
}), makeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", attrNameToString{
@@ -2071,7 +2070,6 @@ func TestCcLibraryProtoFull(t *testing.T) {
name: "foo",
srcs: ["foo.proto"],
proto: {
canonical_path_from_root: false,
type: "full",
},
include_build_directory: false,
@@ -2099,7 +2097,6 @@ func TestCcLibraryProtoLite(t *testing.T) {
name: "foo",
srcs: ["foo.proto"],
proto: {
canonical_path_from_root: false,
type: "lite",
},
include_build_directory: false,
@@ -2127,7 +2124,6 @@ func TestCcLibraryProtoExportHeaders(t *testing.T) {
name: "foo",
srcs: ["foo.proto"],
proto: {
canonical_path_from_root: false,
export_proto_headers: true,
},
include_build_directory: false,
@@ -2161,7 +2157,6 @@ cc_library {
name: "a",
srcs: [":a_fg_proto"],
proto: {
canonical_path_from_root: false,
export_proto_headers: true,
},
include_build_directory: false,
@@ -2171,7 +2166,6 @@ cc_library {
name: "b",
srcs: [":b_protos"],
proto: {
canonical_path_from_root: false,
export_proto_headers: true,
},
include_build_directory: false,
@@ -2181,7 +2175,6 @@ cc_library {
name: "c",
srcs: [":c-proto-srcs"],
proto: {
canonical_path_from_root: false,
export_proto_headers: true,
},
include_build_directory: false,
@@ -2191,7 +2184,6 @@ cc_library {
name: "d",
srcs: [":proto-srcs-d"],
proto: {
canonical_path_from_root: false,
export_proto_headers: true,
},
include_build_directory: false,

1
bp2build/cc_library_shared_conversion_test.go
View File

@@ -431,7 +431,6 @@ func TestCcLibrarySharedProto(t *testing.T) {
name: "foo",
srcs: ["foo.proto"],
proto: {
canonical_path_from_root: false,
export_proto_headers: true,
},
include_build_directory: false,

1
bp2build/cc_library_static_conversion_test.go
View File

@@ -1436,7 +1436,6 @@ func TestCcLibraryStaticProto(t *testing.T) {
name: "foo",
srcs: ["foo.proto"],
proto: {
canonical_path_from_root: false,
export_proto_headers: true,
},
include_build_directory: false,