Fix InstallBypassMake symlink dependencies
Host symlinks cannot use order-only dependencies because they may be used as part of the dependency chain on a tool, and an order-only dependency would cause the target of the symlink not to be updated. Use regular dependencies instead. Bug: 204136549 Fixes: 205674000 Test: TestInstallBypassMake Change-Id: Ib3f4ee143e94d1995ec6c60d314e7c91e57cc775
This commit is contained in:
@@ -2953,6 +2953,10 @@ func (m *moduleContext) InstallSymlink(installPath InstallPath, name string, src
|
||||
to: fullInstallPath,
|
||||
})
|
||||
} else {
|
||||
// The symlink doesn't need updating when the target is modified, but we sometimes
|
||||
// have a dependency on a symlink to a binary instead of to the binary directly, and
|
||||
// the mtime of the symlink must be updated when the binary is modified, so use a
|
||||
// normal dependency here instead of an order-only dependency.
|
||||
m.Build(pctx, BuildParams{
|
||||
Rule: Symlink,
|
||||
Description: "install symlink " + fullInstallPath.Base(),
|
||||
|
Reference in New Issue
Block a user