StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Apply pylint to cc/symbolfile"

Browse Source
This commit is contained in:
Treehugger Robot
2021-08-17 22:44:37 +00:00
committed by Gerrit Code Review
parent 0dd067d309 73de70264a
commit 68a240badb
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cc/symbolfile/__init__.py
View File

@@ -329,7 +329,7 @@ class SymbolFileParser:
def parse(self) -> List[Version]: def parse(self) -> List[Version]:
"""Parses the symbol file and returns a list of Version objects.""" """Parses the symbol file and returns a list of Version objects."""
versions = [] versions = []
while self.next_line() != '': while self.next_line():
assert self.current_line is not None assert self.current_line is not None
if '{' in self.current_line: if '{' in self.current_line:
versions.append(self.parse_version()) versions.append(self.parse_version())
@@ -376,7 +376,7 @@ class SymbolFileParser:
symbols: List[Symbol] = [] symbols: List[Symbol] = []
global_scope = True global_scope = True
cpp_symbols = False cpp_symbols = False
while self.next_line() != '': while self.next_line():
if '}' in self.current_line: if '}' in self.current_line:
# Line is something like '} BASE; # tags'. Both base and tags # Line is something like '} BASE; # tags'. Both base and tags
# are optional here. # are optional here.
@@ -428,11 +428,11 @@ class SymbolFileParser:
A return value of '' indicates EOF. A return value of '' indicates EOF.
""" """
line = self.input_file.readline() line = self.input_file.readline()
while line.strip() == '' or line.strip().startswith('#'): while not line.strip() or line.strip().startswith('#'):
line = self.input_file.readline() line = self.input_file.readline()
# We want to skip empty lines, but '' indicates EOF. # We want to skip empty lines, but '' indicates EOF.
if line == '': if not line:
break break
self.current_line = line self.current_line = line
return self.current_line return self.current_line