StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Disable() must not be enabled unexpectedly"

Browse Source
This commit is contained in:
Treehugger Robot
2020-08-01 08:40:06 +00:00
committed by Gerrit Code Review
parent fcb53d9d2a 32f053b97e
commit 6aed6a385e
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
android/module.go
View File

@@ -548,6 +548,9 @@ type commonProperties struct {
SkipInstall bool `blueprint:"mutated"` SkipInstall bool `blueprint:"mutated"`
// Disabled by mutators. If set to true, it overrides Enabled property.
ForcedDisabled bool `blueprint:"mutated"`
NamespaceExportedToMake bool `blueprint:"mutated"` NamespaceExportedToMake bool `blueprint:"mutated"`
MissingDeps []string `blueprint:"mutated"` MissingDeps []string `blueprint:"mutated"`
@@ -1022,6 +1025,9 @@ func (m *ModuleBase) PartitionTag(config DeviceConfig) string {
} }
func (m *ModuleBase) Enabled() bool { func (m *ModuleBase) Enabled() bool {
if m.commonProperties.ForcedDisabled {
return false
}
if m.commonProperties.Enabled == nil { if m.commonProperties.Enabled == nil {
return !m.Os().DefaultDisabled return !m.Os().DefaultDisabled
} }
@@ -1029,7 +1035,7 @@ func (m *ModuleBase) Enabled() bool {
} }
func (m *ModuleBase) Disable() { func (m *ModuleBase) Disable() {
m.commonProperties.Enabled = proptools.BoolPtr(false) m.commonProperties.ForcedDisabled = true
} }
func (m *ModuleBase) SkipInstall() { func (m *ModuleBase) SkipInstall() {