StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change the approach to decide whether to upload metrics.

Browse Source 
1. Don't upload if the uploader binary is not present.

Bug: b/193703183
Test: Run the following tests locally:
1. run "go test ." in build/soong/ui/build
2. create vendor/google/misc/metrics_uploader_prebuilt/metrics_uploader.sh
and run m nothing to ensure metrics_uploader.sh was called
3. remove the file created in step 2 then run m nothing and ensure it
doesn't attempt uploading

Change-Id: I081a5510b3f30480720c3e7dd235623c805fa7a4
This commit is contained in:
Yu Liu
2021-07-27 14:29:06 -07:00
parent 37c3dd3276
commit 6e13b40628
5 changed files with 97 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ui/metrics/metrics.go
View File

@@ -25,16 +25,11 @@ package metrics
// that captures the metrics and is them added as a perfInfo into the set
// of the collected metrics. Finally, when soong_ui has finished the build,
// the defer Dump function is invoked to store the collected metrics to the
// raw protobuf file in the $OUT directory.
//
// There is one additional step that occurs after the raw protobuf file is written.
// If the configuration environment variable ANDROID_ENABLE_METRICS_UPLOAD is
// set with the path, the raw protobuf file is uploaded to the destination. See
// ui/build/upload.go for more details. The filename of the raw protobuf file
// and the list of files to be uploaded is defined in cmd/soong_ui/main.go.
//
// See ui/metrics/event.go for the explanation of what an event is and how
// the metrics system is a stack based system.
// raw protobuf file in the $OUT directory and this raw protobuf file will be
// uploaded to the destination. See ui/build/upload.go for more details. The
// filename of the raw protobuf file and the list of files to be uploaded is
// defined in cmd/soong_ui/main.go. See ui/metrics/event.go for the explanation
// of what an event is and how the metrics system is a stack based system.
import (
"io/ioutil"