StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check if "instrumentation" and "sampling" are set together

Browse Source 
Setting these simultaneously is an error.

Test: Check error generation in a test module

Change-Id: I2ee127fa1b7157fa5f4489d2541ff023c64f9ba5
This commit is contained in:
Pirama Arumuga Nainar
2017-10-05 10:25:00 -07:00
parent 49b53d5c7c
commit 6fc8d9126c
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cc/pgo.go
View File

@@ -124,13 +124,14 @@ func (props *PgoProperties) isPGO(ctx BaseModuleContext) bool {
} }
// Sampling not supported yet // Sampling not supported yet
//
// TODO When sampling support is turned on, check that instrumentation and
// sampling are not simultaneously specified
if isSampling { if isSampling {
ctx.PropertyErrorf("pgo.sampling", "\"sampling\" is not supported yet)") ctx.PropertyErrorf("pgo.sampling", "\"sampling\" is not supported yet)")
} }
if isSampling && isInstrumentation {
ctx.PropertyErrorf("pgo", "Exactly one of \"instrumentation\" and \"sampling\" properties must be set")
}
return true return true
} }