Add signing certificate lineage support to soong
Test: app_test Bug: 153366049 Change-Id: I65a92d6c40057dcc01950991fb7be485de1c9080
This commit is contained in:
@@ -1115,7 +1115,8 @@ func TestCertificates(t *testing.T) {
|
||||
name string
|
||||
bp string
|
||||
certificateOverride string
|
||||
expected string
|
||||
expectedLineage string
|
||||
expectedCertificate string
|
||||
}{
|
||||
{
|
||||
name: "default",
|
||||
@@ -1127,7 +1128,8 @@ func TestCertificates(t *testing.T) {
|
||||
}
|
||||
`,
|
||||
certificateOverride: "",
|
||||
expected: "build/make/target/product/security/testkey.x509.pem build/make/target/product/security/testkey.pk8",
|
||||
expectedLineage: "",
|
||||
expectedCertificate: "build/make/target/product/security/testkey.x509.pem build/make/target/product/security/testkey.pk8",
|
||||
},
|
||||
{
|
||||
name: "module certificate property",
|
||||
@@ -1145,7 +1147,8 @@ func TestCertificates(t *testing.T) {
|
||||
}
|
||||
`,
|
||||
certificateOverride: "",
|
||||
expected: "cert/new_cert.x509.pem cert/new_cert.pk8",
|
||||
expectedLineage: "",
|
||||
expectedCertificate: "cert/new_cert.x509.pem cert/new_cert.pk8",
|
||||
},
|
||||
{
|
||||
name: "path certificate property",
|
||||
@@ -1158,7 +1161,8 @@ func TestCertificates(t *testing.T) {
|
||||
}
|
||||
`,
|
||||
certificateOverride: "",
|
||||
expected: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
|
||||
expectedLineage: "",
|
||||
expectedCertificate: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
|
||||
},
|
||||
{
|
||||
name: "certificate overrides",
|
||||
@@ -1176,7 +1180,28 @@ func TestCertificates(t *testing.T) {
|
||||
}
|
||||
`,
|
||||
certificateOverride: "foo:new_certificate",
|
||||
expected: "cert/new_cert.x509.pem cert/new_cert.pk8",
|
||||
expectedLineage: "",
|
||||
expectedCertificate: "cert/new_cert.x509.pem cert/new_cert.pk8",
|
||||
},
|
||||
{
|
||||
name: "certificate lineage",
|
||||
bp: `
|
||||
android_app {
|
||||
name: "foo",
|
||||
srcs: ["a.java"],
|
||||
certificate: ":new_certificate",
|
||||
lineage: "lineage.bin",
|
||||
sdk_version: "current",
|
||||
}
|
||||
|
||||
android_app_certificate {
|
||||
name: "new_certificate",
|
||||
certificate: "cert/new_cert",
|
||||
}
|
||||
`,
|
||||
certificateOverride: "",
|
||||
expectedLineage: "--lineage lineage.bin",
|
||||
expectedCertificate: "cert/new_cert.x509.pem cert/new_cert.pk8",
|
||||
},
|
||||
}
|
||||
|
||||
@@ -1192,9 +1217,14 @@ func TestCertificates(t *testing.T) {
|
||||
foo := ctx.ModuleForTests("foo", "android_common")
|
||||
|
||||
signapk := foo.Output("foo.apk")
|
||||
signFlags := signapk.Args["certificates"]
|
||||
if test.expected != signFlags {
|
||||
t.Errorf("Incorrect signing flags, expected: %q, got: %q", test.expected, signFlags)
|
||||
signCertificateFlags := signapk.Args["certificates"]
|
||||
if test.expectedCertificate != signCertificateFlags {
|
||||
t.Errorf("Incorrect signing flags, expected: %q, got: %q", test.expectedCertificate, signCertificateFlags)
|
||||
}
|
||||
|
||||
signFlags := signapk.Args["flags"]
|
||||
if test.expectedLineage != signFlags {
|
||||
t.Errorf("Incorrect signing flags, expected: %q, got: %q", test.expectedLineage, signFlags)
|
||||
}
|
||||
})
|
||||
}
|
||||
@@ -1368,6 +1398,7 @@ func TestOverrideAndroidApp(t *testing.T) {
|
||||
name: "bar",
|
||||
base: "foo",
|
||||
certificate: ":new_certificate",
|
||||
lineage: "lineage.bin",
|
||||
logging_parent: "bah",
|
||||
}
|
||||
|
||||
@@ -1388,7 +1419,8 @@ func TestOverrideAndroidApp(t *testing.T) {
|
||||
variantName string
|
||||
apkName string
|
||||
apkPath string
|
||||
signFlag string
|
||||
certFlag string
|
||||
lineageFlag string
|
||||
overrides []string
|
||||
aaptFlag string
|
||||
logging_parent string
|
||||
@@ -1397,7 +1429,8 @@ func TestOverrideAndroidApp(t *testing.T) {
|
||||
moduleName: "foo",
|
||||
variantName: "android_common",
|
||||
apkPath: "/target/product/test_device/system/app/foo/foo.apk",
|
||||
signFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
|
||||
certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
|
||||
lineageFlag: "",
|
||||
overrides: []string{"qux"},
|
||||
aaptFlag: "",
|
||||
logging_parent: "",
|
||||
@@ -1406,7 +1439,8 @@ func TestOverrideAndroidApp(t *testing.T) {
|
||||
moduleName: "bar",
|
||||
variantName: "android_common_bar",
|
||||
apkPath: "/target/product/test_device/system/app/bar/bar.apk",
|
||||
signFlag: "cert/new_cert.x509.pem cert/new_cert.pk8",
|
||||
certFlag: "cert/new_cert.x509.pem cert/new_cert.pk8",
|
||||
lineageFlag: "--lineage lineage.bin",
|
||||
overrides: []string{"qux", "foo"},
|
||||
aaptFlag: "",
|
||||
logging_parent: "bah",
|
||||
@@ -1415,7 +1449,8 @@ func TestOverrideAndroidApp(t *testing.T) {
|
||||
moduleName: "baz",
|
||||
variantName: "android_common_baz",
|
||||
apkPath: "/target/product/test_device/system/app/baz/baz.apk",
|
||||
signFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
|
||||
certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
|
||||
lineageFlag: "",
|
||||
overrides: []string{"qux", "foo"},
|
||||
aaptFlag: "--rename-manifest-package org.dandroid.bp",
|
||||
logging_parent: "",
|
||||
@@ -1440,9 +1475,15 @@ func TestOverrideAndroidApp(t *testing.T) {
|
||||
|
||||
// Check the certificate paths
|
||||
signapk := variant.Output(expected.moduleName + ".apk")
|
||||
signFlag := signapk.Args["certificates"]
|
||||
if expected.signFlag != signFlag {
|
||||
t.Errorf("Incorrect signing flags, expected: %q, got: %q", expected.signFlag, signFlag)
|
||||
certFlag := signapk.Args["certificates"]
|
||||
if expected.certFlag != certFlag {
|
||||
t.Errorf("Incorrect signing flags, expected: %q, got: %q", expected.certFlag, certFlag)
|
||||
}
|
||||
|
||||
// Check the lineage flags
|
||||
lineageFlag := signapk.Args["flags"]
|
||||
if expected.lineageFlag != lineageFlag {
|
||||
t.Errorf("Incorrect signing flags, expected: %q, got: %q", expected.lineageFlag, lineageFlag)
|
||||
}
|
||||
|
||||
// Check if the overrides field values are correctly aggregated.
|
||||
|
Reference in New Issue
Block a user