StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Remove creation of has_stubs in cc_library_shared by bp2build"

Browse Source
This commit is contained in:
Vinh Tran
2022-12-21 03:16:08 +00:00
committed by Gerrit Code Review
parent 003cbe3bc5 83f88cdc8b
commit 72e1d65f05
3 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bp2build/cc_library_conversion_test.go
View File

@@ -1409,7 +1409,6 @@ func makeCcLibraryTargets(name string, attrs AttrNameToString) []string {
"linkopts": true, "linkopts": true,
"strip": true, "strip": true,
"inject_bssl_hash": true, "inject_bssl_hash": true,
"has_stubs": true,
"stubs_symbol_file": true, "stubs_symbol_file": true,
"use_version_lib": true, "use_version_lib": true,
} }
@@ -2712,7 +2711,6 @@ func TestCcLibraryStaticDisabledForSomeArch(t *testing.T) {
func TestCcLibraryStubs(t *testing.T) { func TestCcLibraryStubs(t *testing.T) {
expectedBazelTargets := makeCcLibraryTargets("a", AttrNameToString{ expectedBazelTargets := makeCcLibraryTargets("a", AttrNameToString{
"has_stubs": `True`,
"stubs_symbol_file": `"a.map.txt"`, "stubs_symbol_file": `"a.map.txt"`,
}) })
expectedBazelTargets = append(expectedBazelTargets, makeCcStubSuiteTargets("a", AttrNameToString{ expectedBazelTargets = append(expectedBazelTargets, makeCcStubSuiteTargets("a", AttrNameToString{

1
bp2build/cc_library_shared_conversion_test.go
View File

@@ -543,7 +543,6 @@ cc_library_shared {
]`, ]`,
}), }),
MakeBazelTarget("cc_library_shared", "a", AttrNameToString{ MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
"has_stubs": `True`,
"stubs_symbol_file": `"a.map.txt"`, "stubs_symbol_file": `"a.map.txt"`,
}), }),
}, },

5
cc/library.go
View File

@@ -424,8 +424,6 @@ func libraryBp2Build(ctx android.TopDownMutatorContext, m *Module) {
} }
if compilerAttrs.stubsSymbolFile != nil && len(compilerAttrs.stubsVersions.Value) > 0 { if compilerAttrs.stubsSymbolFile != nil && len(compilerAttrs.stubsVersions.Value) > 0 {
hasStubs := true
sharedTargetAttrs.Has_stubs.SetValue(&hasStubs)
sharedTargetAttrs.Stubs_symbol_file = compilerAttrs.stubsSymbolFile sharedTargetAttrs.Stubs_symbol_file = compilerAttrs.stubsSymbolFile
} }
@@ -2939,8 +2937,6 @@ func sharedOrStaticLibraryBp2Build(ctx android.TopDownMutatorContext, module *Mo
Fdo_profile: compilerAttrs.fdoProfile, Fdo_profile: compilerAttrs.fdoProfile,
} }
if compilerAttrs.stubsSymbolFile != nil && len(compilerAttrs.stubsVersions.Value) > 0 { if compilerAttrs.stubsSymbolFile != nil && len(compilerAttrs.stubsVersions.Value) > 0 {
hasStubs := true
sharedLibAttrs.Has_stubs.SetValue(&hasStubs)
sharedLibAttrs.Stubs_symbol_file = compilerAttrs.stubsSymbolFile sharedLibAttrs.Stubs_symbol_file = compilerAttrs.stubsSymbolFile
} }
attrs = sharedLibAttrs attrs = sharedLibAttrs
@@ -3026,7 +3022,6 @@ type bazelCcLibrarySharedAttributes struct {
Features bazel.StringListAttribute Features bazel.StringListAttribute
Has_stubs bazel.BoolAttribute
Stubs_symbol_file *string Stubs_symbol_file *string
Inject_bssl_hash bazel.BoolAttribute Inject_bssl_hash bazel.BoolAttribute