StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix error handling

Browse Source 
We log an error message, but then carry on and attempt to use the invalid impl, which then panics.

Change-Id: I440cdf728cb32479a10cbaecc5aadbdd97f215de
This commit is contained in:
Alan Stokes
2022-11-01 14:05:08 +00:00
parent af9dbb30f6
commit 73d3245e30
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
cc/ndk_library.go
View File

@@ -307,6 +307,7 @@ func (this *stubDecorator) findImplementationLibrary(ctx ModuleContext) android.
impl, ok := dep.(*Module) impl, ok := dep.(*Module)
if !ok { if !ok {
ctx.ModuleErrorf("Implementation for stub is not correct module type") ctx.ModuleErrorf("Implementation for stub is not correct module type")
return nil
} }
output := impl.UnstrippedOutputFile() output := impl.UnstrippedOutputFile()
if output == nil { if output == nil {