StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Handle Clang's change of defaults from -fcommon to -fno-common" into main

Browse Source
This commit is contained in:
Zijun Zhao
2023-09-13 17:34:47 +00:00
committed by Gerrit Code Review
parent b46969dd3d 5bcebba331
commit 748f8fb624
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cc/config/global.go
View File

@@ -67,10 +67,6 @@ var (
// not emit the table by default on Android since NDK still uses GNU binutils. // not emit the table by default on Android since NDK still uses GNU binutils.
"-faddrsig", "-faddrsig",
// Turn on -fcommon explicitly, since Clang now defaults to -fno-common. The cleanup bug
// tracking this is http://b/151457797.
"-fcommon",
// Help catch common 32/64-bit errors. // Help catch common 32/64-bit errors.
"-Werror=int-conversion", "-Werror=int-conversion",
@@ -253,6 +249,8 @@ var (
// (anything for which IsThirdPartyPath() in build/soong/android/paths.go // (anything for which IsThirdPartyPath() in build/soong/android/paths.go
// returns true - includes external/, most of vendor/ and most of hardware/) // returns true - includes external/, most of vendor/ and most of hardware/)
noOverrideExternalGlobalCflags = []string{ noOverrideExternalGlobalCflags = []string{
// http://b/151457797
"-fcommon",
// http://b/191699019 // http://b/191699019
"-Wno-format-insufficient-args", "-Wno-format-insufficient-args",
// http://b/296321145 // http://b/296321145