StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Revert "Skip old file cleanup for non-full builds.""

Browse Source
This commit is contained in:
Colin Cross
2021-03-10 22:53:43 +00:00
committed by Gerrit Code Review
parent 29e98e5ede 41ad6b632f
commit 75a38ba791
3 changed files with 1 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ui/build/config.go
View File

@@ -56,7 +56,6 @@ type configImpl struct {
katiSuffix string katiSuffix string
targetDevice string targetDevice string
targetDeviceDir string targetDeviceDir string
fullBuild bool
// Autodetected // Autodetected
totalRAM uint64 totalRAM uint64
@@ -792,14 +791,6 @@ func (c *configImpl) SetTargetDevice(device string) {
c.targetDevice = device c.targetDevice = device
} }
func (c *configImpl) FullBuild() bool {
return c.fullBuild
}
func (c *configImpl) SetFullBuild(fullBuild bool) {
c.fullBuild = fullBuild
}
func (c *configImpl) TargetBuildVariant() string { func (c *configImpl) TargetBuildVariant() string {
if v, ok := c.environ.Get("TARGET_BUILD_VARIANT"); ok { if v, ok := c.environ.Get("TARGET_BUILD_VARIANT"); ok {
return v return v

4
ui/build/dumpvars.go
View File

@@ -214,9 +214,6 @@ func runMakeProductConfig(ctx Context, config Config) {
// So that later Kati runs can find BoardConfig.mk faster // So that later Kati runs can find BoardConfig.mk faster
"TARGET_DEVICE_DIR", "TARGET_DEVICE_DIR",
// To decide whether to skip the old installed cleanup step.
"FULL_BUILD",
// Whether --werror_overriding_commands will work // Whether --werror_overriding_commands will work
"BUILD_BROKEN_DUP_RULES", "BUILD_BROKEN_DUP_RULES",
@@ -281,7 +278,6 @@ func runMakeProductConfig(ctx Context, config Config) {
config.SetNinjaArgs(strings.Fields(makeVars["NINJA_GOALS"])) config.SetNinjaArgs(strings.Fields(makeVars["NINJA_GOALS"]))
config.SetTargetDevice(makeVars["TARGET_DEVICE"]) config.SetTargetDevice(makeVars["TARGET_DEVICE"])
config.SetTargetDeviceDir(makeVars["TARGET_DEVICE_DIR"]) config.SetTargetDeviceDir(makeVars["TARGET_DEVICE_DIR"])
config.SetFullBuild(makeVars["FULL_BUILD"] == "true")
config.SetBuildBrokenDupRules(makeVars["BUILD_BROKEN_DUP_RULES"] == "true") config.SetBuildBrokenDupRules(makeVars["BUILD_BROKEN_DUP_RULES"] == "true")
config.SetBuildBrokenUsesNetwork(makeVars["BUILD_BROKEN_USES_NETWORK"] == "true") config.SetBuildBrokenUsesNetwork(makeVars["BUILD_BROKEN_USES_NETWORK"] == "true")

6
ui/build/kati.go
View File

@@ -229,11 +229,7 @@ func runKatiBuild(ctx Context, config Config) {
// Cleanup steps. // Cleanup steps.
cleanCopyHeaders(ctx, config) cleanCopyHeaders(ctx, config)
// Skip the old installed file cleanup step for few non-full build goals as we don't create cleanOldInstalledFiles(ctx, config)
// an installed file list for them.
if config.FullBuild() {
cleanOldInstalledFiles(ctx, config)
}
} }
// Clean out obsolete header files on the disk that were *not copied* during the // Clean out obsolete header files on the disk that were *not copied* during the