StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Allowlist build files in external/python/absl-py"

Browse Source 
Revert submission 2308141-colefaust_run_b_from_out_folder

Reason for revert: Breaks CI due to more instances of the bazel shutdown issue
Reverted Changes:
I51c28e232:Allowlist build files in external/python/absl-py
I9e6530d95:Cd into the bazel workspace instead of using --pac...

Change-Id: Ice47ef2baaef9976546f9562dc7dd9b19b383d59
This commit is contained in:
Cole Faust
2022-11-30 05:16:30 +00:00
committed by Gerrit Code Review
parent 93dc19d39d
commit 762c2def20
3 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
android/allowlists/allowlists.go
View File

@@ -364,7 +364,6 @@ var (
"external/guava":/* recursive = */ true, "external/guava":/* recursive = */ true,
"external/jsr305":/* recursive = */ true, "external/jsr305":/* recursive = */ true,
"external/protobuf":/* recursive = */ false, "external/protobuf":/* recursive = */ false,
"external/python/absl-py":/* recursive = */ true,
// this BUILD file is globbed by //external/icu/icu4c/source:icu4c_test_data's "data/**/*". // this BUILD file is globbed by //external/icu/icu4c/source:icu4c_test_data's "data/**/*".
"external/icu/icu4c/source/data/unidata/norm2":/* recursive = */ false, "external/icu/icu4c/source/data/unidata/norm2":/* recursive = */ false,

12
tests/bp2build_bazel_test.sh
View File

@@ -65,7 +65,7 @@ EOF
outdir=out2 outdir=out2
trap "rm -rf $outdir" EXIT trap "rm -rf $outdir" EXIT
# Modify OUT_DIR in a subshell so it doesn't affect the top level one. # Modify OUT_DIR in a subshell so it doesn't affect the top level one.
(export OUT_DIR=$outdir; run_soong bp2build && run_bazel build --config=bp2build --config=ci //a:g) (export OUT_DIR=$outdir; run_soong bp2build && run_bazel build --config=bp2build //a:g)
} }
test_different_relative_outdir test_different_relative_outdir
@@ -87,7 +87,7 @@ EOF
outdir=$(mktemp -t -d st.XXXXX) outdir=$(mktemp -t -d st.XXXXX)
trap 'rm -rf $outdir' EXIT trap 'rm -rf $outdir' EXIT
# Modify OUT_DIR in a subshell so it doesn't affect the top level one. # Modify OUT_DIR in a subshell so it doesn't affect the top level one.
(export OUT_DIR=$outdir; run_soong bp2build && run_bazel build --config=bp2build --config=ci //a:g) (export OUT_DIR=$outdir; run_soong bp2build && run_bazel build --config=bp2build //a:g)
} }
test_different_absolute_outdir test_different_absolute_outdir
@@ -146,7 +146,7 @@ EOF
fi fi
# NOTE: We don't actually use the extra BUILD file for anything here # NOTE: We don't actually use the extra BUILD file for anything here
run_bazel build --config=android --config=bp2build --config=ci //foo/... run_bazel build --config=android --package_path=out/soong/workspace //foo/...
local the_answer_file="bazel-out/android_target-fastbuild/bin/foo/convertible_soong_module/the_answer.txt" local the_answer_file="bazel-out/android_target-fastbuild/bin/foo/convertible_soong_module/the_answer.txt"
if [[ ! -f "${the_answer_file}" ]]; then if [[ ! -f "${the_answer_file}" ]]; then
@@ -191,10 +191,10 @@ EOF
run_soong bp2build run_soong bp2build
run_bazel build --config=android --config=bp2build --config=ci //a:qq run_bazel build --config=android --package_path=out/soong/workspace //a:qq
local -r output_mtime1=$(stat -c "%y" bazel-bin/a/_objs/qq/qq.o) local -r output_mtime1=$(stat -c "%y" bazel-bin/a/_objs/qq/qq.o)
run_bazel build --config=android --config=bp2build --config=ci //a:qq run_bazel build --config=android --package_path=out/soong/workspace //a:qq
local -r output_mtime2=$(stat -c "%y" bazel-bin/a/_objs/qq/qq.o) local -r output_mtime2=$(stat -c "%y" bazel-bin/a/_objs/qq/qq.o)
if [[ "$output_mtime1" != "$output_mtime2" ]]; then if [[ "$output_mtime1" != "$output_mtime2" ]]; then
@@ -205,7 +205,7 @@ EOF
#define QQ 2 #define QQ 2
EOF EOF
run_bazel build --config=android --config=bp2build --config=ci //a:qq run_bazel build --config=android --package_path=out/soong/workspace //a:qq
local -r output_mtime3=$(stat -c "%y" bazel-bin/a/_objs/qq/qq.o) local -r output_mtime3=$(stat -c "%y" bazel-bin/a/_objs/qq/qq.o)
if [[ "$output_mtime1" == "$output_mtime3" ]]; then if [[ "$output_mtime1" == "$output_mtime3" ]]; then

3
tests/run_integration_tests.sh
View File

@@ -12,5 +12,4 @@ TOP="$(readlink -f "$(dirname "$0")"/../../..)"
# The following tests build against the full source tree and don't rely on the # The following tests build against the full source tree and don't rely on the
# mock client. # mock client.
# TODO(b/260278287) the bazel server won't shut down for some reason when run on the build server "$TOP/build/soong/tests/apex_comparison_tests.sh"
# "$TOP/build/soong/tests/apex_comparison_tests.sh"