StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "RBE should not copy source file back to local"

Browse Source
This commit is contained in:
Chih-hung Hsieh
2021-09-01 20:43:00 +00:00
committed by Gerrit Code Review
parent 0364846a73 fde8e6d387
commit 7686708a43
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cc/builder.go
View File

@@ -205,11 +205,13 @@ var (
Labels: map[string]string{"type": "lint", "tool": "clang-tidy", "lang": "cpp"}, Labels: map[string]string{"type": "lint", "tool": "clang-tidy", "lang": "cpp"},
ExecStrategy: "${config.REClangTidyExecStrategy}", ExecStrategy: "${config.REClangTidyExecStrategy}",
Inputs: []string{"$in"}, Inputs: []string{"$in"},
// OutputFile here is $in for remote-execution since its possible that // Although clang-tidy has an option to "fix" source files, that feature is hardly useable
// clang-tidy modifies the given input file itself and $out refers to the // under parallel compilation and RBE. So we assume no OutputFiles here.
// ".tidy" file generated for ninja-dependency reasons. // The clang-tidy fix option is best run locally in single thread.
OutputFiles: []string{"$in"}, // Copying source file back to local caused two problems:
Platform: map[string]string{remoteexec.PoolKey: "${config.REClangTidyPool}"}, // (1) New timestamps trigger clang and clang-tidy compilations again.
// (2) Changing source files caused concurrent clang or clang-tidy jobs to crash.
Platform: map[string]string{remoteexec.PoolKey: "${config.REClangTidyPool}"},
}, []string{"cFlags", "tidyFlags"}, []string{}) }, []string{"cFlags", "tidyFlags"}, []string{})
_ = pctx.SourcePathVariable("yasmCmd", "prebuilts/misc/${config.HostPrebuiltTag}/yasm/yasm") _ = pctx.SourcePathVariable("yasmCmd", "prebuilts/misc/${config.HostPrebuiltTag}/yasm/yasm")