StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow enabling -Wreorder-init-list from Android.bp.

Browse Source 
I want to make this warning an error in my project and the
current setup is preventing me from doing so.

This has to be -Wno-error=reorder-init-list and not
-Wno-reorder-init-list because the later is overridden by some
modules explicitly enabling warning sets. -Wno-* flags are
overridden by -W* flags coming later in the command line,
but -Wno-error=* flags are only overridden by later -Werror=
flags.

Bug: 145210666
Test: presubmit
Change-Id: Ia08f8a20da37cdc57167324b0cd19413d8786990
This commit is contained in:
Krzysztof Kosiński
2023-08-18 21:23:52 +00:00
parent 4315796730
commit 78425e510d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cc/config/global.go
View File

@@ -101,6 +101,9 @@ var (
// Warnings from clang-12 // Warnings from clang-12
"-Wno-gnu-folding-constant", "-Wno-gnu-folding-constant",
// http://b/145210666
"-Wno-error=reorder-init-list",
// Calls to the APIs that are newer than the min sdk version of the caller should be // Calls to the APIs that are newer than the min sdk version of the caller should be
// guarded with __builtin_available. // guarded with __builtin_available.
"-Wunguarded-availability", "-Wunguarded-availability",
@@ -218,8 +221,6 @@ var (
// new warnings are fixed. // new warnings are fixed.
"-Wno-tautological-constant-compare", "-Wno-tautological-constant-compare",
"-Wno-tautological-type-limit-compare", "-Wno-tautological-type-limit-compare",
// http://b/145210666
"-Wno-reorder-init-list",
// http://b/145211066 // http://b/145211066
"-Wno-implicit-int-float-conversion", "-Wno-implicit-int-float-conversion",
// New warnings to be fixed after clang-r377782. // New warnings to be fixed after clang-r377782.