StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix Protobuf importing issue for embedded Python"

Browse Source
This commit is contained in:
Treehugger Robot
2018-05-23 20:24:42 +00:00
committed by Gerrit Code Review
parent a0a7fc16bf f0c4e4339a
commit 78a01965d0
2 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
python/proto.go
View File

@@ -30,14 +30,14 @@ var (
blueprint.RuleParams{
Command: `rm -rf $out.tmp && mkdir -p $out.tmp && ` +
`$protocCmd --python_out=$out.tmp --dependency_out=$out.d -I $protoBase $protoFlags $in && ` +
`$parCmd -o $out -P $pkgPath -C $out.tmp -D $out.tmp && rm -rf $out.tmp`,
`$parCmd -o $out $pkgPathArgs -C $out.tmp -D $out.tmp && rm -rf $out.tmp`,
CommandDeps: []string{
"$protocCmd",
"$parCmd",
},
Depfile: "${out}.d",
Deps: blueprint.DepsGCC,
}, "protoBase", "protoFlags", "pkgPath")
}, "protoBase", "protoFlags", "pkgPathArgs")
)
func genProto(ctx android.ModuleContext, p *android.ProtoProperties,
@@ -53,6 +53,10 @@ func genProto(ctx android.ModuleContext, p *android.ProtoProperties,
protoBase = strings.TrimSuffix(protoFile.String(), protoFile.Rel())
}
var pkgPathArgs string
if pkgPath != "" {
pkgPathArgs = "-P " + pkgPath
}
ctx.Build(pctx, android.BuildParams{
Rule: proto,
Description: "protoc " + protoFile.Rel(),
@@ -61,7 +65,7 @@ func genProto(ctx android.ModuleContext, p *android.ProtoProperties,
Args: map[string]string{
"protoBase": protoBase,
"protoFlags": strings.Join(protoFlags, " "),
"pkgPath": pkgPath,
"pkgPathArgs": pkgPathArgs,
},
})

6
python/python.go
View File

@@ -420,18 +420,22 @@ func (p *Module) GeneratePythonBuildActions(ctx android.ModuleContext) {
// pkg_path starts from "internal/" implicitly.
pkgPath = filepath.Join(internal, pkgPath)
} else {
if !p.isEmbeddedLauncherEnabled(p.properties.Actual_version) {
// pkg_path starts from "runfiles/" implicitly.
pkgPath = filepath.Join(runFiles, pkgPath)
}
}
} else {
if p.properties.Is_internal != nil && *p.properties.Is_internal {
// pkg_path starts from "runfiles/" implicitly.
pkgPath = internal
} else {
if !p.isEmbeddedLauncherEnabled(p.properties.Actual_version) {
// pkg_path starts from "runfiles/" implicitly.
pkgPath = runFiles
}
}
}
p.genModulePathMappings(ctx, pkgPath, expandedSrcs, expandedData)
@@ -520,7 +524,9 @@ func (p *Module) createSrcsZip(ctx android.ModuleContext, pkgPath string) androi
sort.Strings(keys)
parArgs := []string{}
if pkgPath != "" {
parArgs = append(parArgs, `-P `+pkgPath)
}
implicits := android.Paths{}
for _, k := range keys {
parArgs = append(parArgs, `-C `+k)