Merge "VNDK listing contains device modules only" into rvc-dev
This commit is contained in:
committed by
Android (Google) Code Review
commit
78d26d169b
@@ -430,6 +430,40 @@ func TestVndk(t *testing.T) {
|
||||
checkVndkLibrariesOutput(t, ctx, "vndkcorevariant.libraries.txt", nil)
|
||||
}
|
||||
|
||||
func TestVndkWithHostSupported(t *testing.T) {
|
||||
ctx := testCc(t, `
|
||||
cc_library {
|
||||
name: "libvndk_host_supported",
|
||||
vendor_available: true,
|
||||
vndk: {
|
||||
enabled: true,
|
||||
},
|
||||
host_supported: true,
|
||||
}
|
||||
|
||||
cc_library {
|
||||
name: "libvndk_host_supported_but_disabled_on_device",
|
||||
vendor_available: true,
|
||||
vndk: {
|
||||
enabled: true,
|
||||
},
|
||||
host_supported: true,
|
||||
enabled: false,
|
||||
target: {
|
||||
host: {
|
||||
enabled: true,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
vndk_libraries_txt {
|
||||
name: "vndkcore.libraries.txt",
|
||||
}
|
||||
`)
|
||||
|
||||
checkVndkLibrariesOutput(t, ctx, "vndkcore.libraries.txt", []string{"libvndk_host_supported.so"})
|
||||
}
|
||||
|
||||
func TestVndkLibrariesTxtAndroidMk(t *testing.T) {
|
||||
bp := `
|
||||
vndk_libraries_txt {
|
||||
|
27
cc/vndk.go
27
cc/vndk.go
@@ -334,16 +334,24 @@ func processVndkLibrary(mctx android.BottomUpMutatorContext, m *Module) {
|
||||
}
|
||||
}
|
||||
|
||||
func IsForVndkApex(mctx android.BottomUpMutatorContext, m *Module) bool {
|
||||
// Sanity check for modules that mustn't be VNDK
|
||||
func shouldSkipVndkMutator(m *Module) bool {
|
||||
if !m.Enabled() {
|
||||
return false
|
||||
return true
|
||||
}
|
||||
|
||||
if !mctx.Device() {
|
||||
return false
|
||||
if !m.Device() {
|
||||
// Skip non-device modules
|
||||
return true
|
||||
}
|
||||
|
||||
if m.Target().NativeBridge == android.NativeBridgeEnabled {
|
||||
// Skip native_bridge modules
|
||||
return true
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
func IsForVndkApex(mctx android.BottomUpMutatorContext, m *Module) bool {
|
||||
if shouldSkipVndkMutator(m) {
|
||||
return false
|
||||
}
|
||||
|
||||
@@ -377,11 +385,8 @@ func VndkMutator(mctx android.BottomUpMutatorContext) {
|
||||
if !ok {
|
||||
return
|
||||
}
|
||||
if !m.Enabled() {
|
||||
return
|
||||
}
|
||||
if m.Target().NativeBridge == android.NativeBridgeEnabled {
|
||||
// Skip native_bridge modules
|
||||
|
||||
if shouldSkipVndkMutator(m) {
|
||||
return
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user