From 7cd41e5a081c42e4029cf945f6b19d1f54474872 Mon Sep 17 00:00:00 2001 From: Anton Hansson Date: Fri, 8 Oct 2021 16:13:10 +0100 Subject: [PATCH] Improve error message for dupe srcs in genrule The previous error message did not really give a good indication of what the problems with my genrule was. Test: Make a broken genrule Change-Id: I4bb67f2792ca5a910f70354f10d0f81f330b5c96 --- genrule/genrule.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/genrule/genrule.go b/genrule/genrule.go index 4dd21351a..7dbe6fa8d 100644 --- a/genrule/genrule.go +++ b/genrule/genrule.go @@ -290,7 +290,7 @@ func (g *Module) GenerateAndroidBuildActions(ctx android.ModuleContext) { if _, exists := locationLabels[label]; !exists { locationLabels[label] = loc } else { - ctx.ModuleErrorf("multiple labels for %q, %q and %q", + ctx.ModuleErrorf("multiple locations for label %q: %q and %q (do you have duplicate srcs entries?)", label, locationLabels[label], loc) } }