diff --git a/java/config/config.go b/java/config/config.go index 7f1ccd510..54a709c5e 100644 --- a/java/config/config.go +++ b/java/config/config.go @@ -28,12 +28,11 @@ import ( var ( pctx = android.NewPackageContext("android/soong/java/config") - // TODO(b/157640067): Don't depend on the legacy API by default in the long term. - DefaultBootclasspathLibraries = []string{"legacy.core.platform.api.stubs", "core-lambda-stubs"} - DefaultSystemModules = "legacy-core-platform-api-stubs-system-modules" - DefaultLibraries = []string{"ext", "framework"} - DefaultLambdaStubsLibrary = "core-lambda-stubs" - SdkLambdaStubsPath = "prebuilts/sdk/tools/core-lambda-stubs.jar" + LegacyCorePlatformBootclasspathLibraries = []string{"legacy.core.platform.api.stubs", "core-lambda-stubs"} + LegacyCorePlatformSystemModules = "legacy-core-platform-api-stubs-system-modules" + FrameworkLibraries = []string{"ext", "framework"} + DefaultLambdaStubsLibrary = "core-lambda-stubs" + SdkLambdaStubsPath = "prebuilts/sdk/tools/core-lambda-stubs.jar" DefaultMakeJacocoExcludeFilter = []string{"org.junit.*", "org.jacoco.*", "org.mockito.*"} DefaultJacocoExcludeFilter = []string{"org.junit.**", "org.jacoco.**", "org.mockito.**"} diff --git a/java/config/makevars.go b/java/config/makevars.go index b355fad87..708a72aa4 100644 --- a/java/config/makevars.go +++ b/java/config/makevars.go @@ -25,9 +25,11 @@ func init() { } func makeVarsProvider(ctx android.MakeVarsContext) { - ctx.Strict("TARGET_DEFAULT_JAVA_LIBRARIES", strings.Join(DefaultLibraries, " ")) - ctx.Strict("TARGET_DEFAULT_BOOTCLASSPATH_LIBRARIES", strings.Join(DefaultBootclasspathLibraries, " ")) - ctx.Strict("DEFAULT_SYSTEM_MODULES", DefaultSystemModules) + ctx.Strict("FRAMEWORK_LIBRARIES", strings.Join(FrameworkLibraries, " ")) + + // These are used by make when LOCAL_PRIVATE_PLATFORM_APIS is set (equivalent to platform_apis in blueprint): + ctx.Strict("LEGACY_CORE_PLATFORM_BOOTCLASSPATH_LIBRARIES", strings.Join(LegacyCorePlatformBootclasspathLibraries, " ")) + ctx.Strict("LEGACY_CORE_PLATFORM_SYSTEM_MODULES", LegacyCorePlatformSystemModules) ctx.Strict("ANDROID_JAVA_HOME", "${JavaHome}") ctx.Strict("ANDROID_JAVA8_HOME", "prebuilts/jdk/jdk8/${hostPrebuiltTag}") diff --git a/java/droiddoc.go b/java/droiddoc.go index 8a6454b27..e37762880 100644 --- a/java/droiddoc.go +++ b/java/droiddoc.go @@ -441,10 +441,10 @@ func (j *Javadoc) addDeps(ctx android.BottomUpMutatorContext) { if ctx.Device() { sdkDep := decodeSdkDep(ctx, sdkContext(j)) if sdkDep.useDefaultLibs { - ctx.AddVariationDependencies(nil, bootClasspathTag, config.DefaultBootclasspathLibraries...) - ctx.AddVariationDependencies(nil, systemModulesTag, config.DefaultSystemModules) + ctx.AddVariationDependencies(nil, bootClasspathTag, config.LegacyCorePlatformBootclasspathLibraries...) + ctx.AddVariationDependencies(nil, systemModulesTag, config.LegacyCorePlatformSystemModules) if sdkDep.hasFrameworkLibs() { - ctx.AddVariationDependencies(nil, libTag, config.DefaultLibraries...) + ctx.AddVariationDependencies(nil, libTag, config.FrameworkLibraries...) } } else if sdkDep.useModule { ctx.AddVariationDependencies(nil, bootClasspathTag, sdkDep.bootclasspath...) diff --git a/java/java.go b/java/java.go index 98586b250..d8cbc1f7d 100644 --- a/java/java.go +++ b/java/java.go @@ -705,17 +705,17 @@ func (j *Module) deps(ctx android.BottomUpMutatorContext) { sdkDep := decodeSdkDep(ctx, sdkContext(j)) if sdkDep.useDefaultLibs { - ctx.AddVariationDependencies(nil, bootClasspathTag, config.DefaultBootclasspathLibraries...) - ctx.AddVariationDependencies(nil, systemModulesTag, config.DefaultSystemModules) + ctx.AddVariationDependencies(nil, bootClasspathTag, config.LegacyCorePlatformBootclasspathLibraries...) + ctx.AddVariationDependencies(nil, systemModulesTag, config.LegacyCorePlatformSystemModules) if sdkDep.hasFrameworkLibs() { - ctx.AddVariationDependencies(nil, libTag, config.DefaultLibraries...) + ctx.AddVariationDependencies(nil, libTag, config.FrameworkLibraries...) } } else if sdkDep.useModule { ctx.AddVariationDependencies(nil, bootClasspathTag, sdkDep.bootclasspath...) ctx.AddVariationDependencies(nil, java9LibTag, sdkDep.java9Classpath...) if j.deviceProperties.EffectiveOptimizeEnabled() && sdkDep.hasStandardLibs() { - ctx.AddVariationDependencies(nil, proguardRaiseTag, config.DefaultBootclasspathLibraries...) - ctx.AddVariationDependencies(nil, proguardRaiseTag, config.DefaultLibraries...) + ctx.AddVariationDependencies(nil, proguardRaiseTag, config.LegacyCorePlatformBootclasspathLibraries...) + ctx.AddVariationDependencies(nil, proguardRaiseTag, config.FrameworkLibraries...) } } if sdkDep.systemModules != "" { diff --git a/java/sdk_test.go b/java/sdk_test.go index e5d322c58..773a70c9e 100644 --- a/java/sdk_test.go +++ b/java/sdk_test.go @@ -49,27 +49,27 @@ func TestClasspath(t *testing.T) { }{ { name: "default", - bootclasspath: config.DefaultBootclasspathLibraries, - system: config.DefaultSystemModules, - java8classpath: config.DefaultLibraries, - java9classpath: config.DefaultLibraries, + bootclasspath: config.LegacyCorePlatformBootclasspathLibraries, + system: config.LegacyCorePlatformSystemModules, + java8classpath: config.FrameworkLibraries, + java9classpath: config.FrameworkLibraries, aidl: "-Iframework/aidl", }, { name: `sdk_version:"core_platform"`, properties: `sdk_version:"core_platform"`, - bootclasspath: config.DefaultBootclasspathLibraries, - system: config.DefaultSystemModules, + bootclasspath: config.LegacyCorePlatformBootclasspathLibraries, + system: config.LegacyCorePlatformSystemModules, java8classpath: []string{}, aidl: "", }, { name: "blank sdk version", properties: `sdk_version: "",`, - bootclasspath: config.DefaultBootclasspathLibraries, - system: config.DefaultSystemModules, - java8classpath: config.DefaultLibraries, - java9classpath: config.DefaultLibraries, + bootclasspath: config.LegacyCorePlatformBootclasspathLibraries, + system: config.LegacyCorePlatformSystemModules, + java8classpath: config.FrameworkLibraries, + java9classpath: config.FrameworkLibraries, aidl: "-Iframework/aidl", }, {