Merge "Add support for d8 --main-dex-rules"

This commit is contained in:
Colin Cross
2021-09-20 20:22:44 +00:00
committed by Gerrit Code Review

View File

@@ -32,6 +32,9 @@ type DexProperties struct {
// list of module-specific flags that will be used for dex compiles // list of module-specific flags that will be used for dex compiles
Dxflags []string `android:"arch_variant"` Dxflags []string `android:"arch_variant"`
// A list of files containing rules that specify the classes to keep in the main dex file.
Main_dex_rules []string `android:"path"`
Optimize struct { Optimize struct {
// If false, disable all optimization. Defaults to true for android_app and android_test // If false, disable all optimization. Defaults to true for android_app and android_test
// modules, false for java_library and java_test modules. // modules, false for java_library and java_test modules.
@@ -164,13 +167,20 @@ var r8, r8RE = pctx.MultiCommandRemoteStaticRules("r8",
}, []string{"outDir", "outDict", "outUsage", "outUsageZip", "outUsageDir", }, []string{"outDir", "outDict", "outUsage", "outUsageZip", "outUsageDir",
"r8Flags", "zipFlags", "tmpJar"}, []string{"implicits"}) "r8Flags", "zipFlags", "tmpJar"}, []string{"implicits"})
func (d *dexer) dexCommonFlags(ctx android.ModuleContext, minSdkVersion android.SdkSpec) []string { func (d *dexer) dexCommonFlags(ctx android.ModuleContext,
flags := d.dexProperties.Dxflags minSdkVersion android.SdkSpec) (flags []string, deps android.Paths) {
flags = d.dexProperties.Dxflags
// Translate all the DX flags to D8 ones until all the build files have been migrated // Translate all the DX flags to D8 ones until all the build files have been migrated
// to D8 flags. See: b/69377755 // to D8 flags. See: b/69377755
flags = android.RemoveListFromList(flags, flags = android.RemoveListFromList(flags,
[]string{"--core-library", "--dex", "--multi-dex"}) []string{"--core-library", "--dex", "--multi-dex"})
for _, f := range android.PathsForModuleSrc(ctx, d.dexProperties.Main_dex_rules) {
flags = append(flags, "--main-dex-rules", f.String())
deps = append(deps, f)
}
if ctx.Config().Getenv("NO_OPTIMIZE_DX") != "" { if ctx.Config().Getenv("NO_OPTIMIZE_DX") != "" {
flags = append(flags, "--debug") flags = append(flags, "--debug")
} }
@@ -187,7 +197,7 @@ func (d *dexer) dexCommonFlags(ctx android.ModuleContext, minSdkVersion android.
} }
flags = append(flags, "--min-api "+strconv.Itoa(effectiveVersion.FinalOrFutureInt())) flags = append(flags, "--min-api "+strconv.Itoa(effectiveVersion.FinalOrFutureInt()))
return flags return flags, deps
} }
func d8Flags(flags javaBuilderFlags) (d8Flags []string, d8Deps android.Paths) { func d8Flags(flags javaBuilderFlags) (d8Flags []string, d8Deps android.Paths) {
@@ -286,7 +296,7 @@ func (d *dexer) compileDex(ctx android.ModuleContext, flags javaBuilderFlags, mi
zipFlags += " -L 0" zipFlags += " -L 0"
} }
commonFlags := d.dexCommonFlags(ctx, minSdkVersion) commonFlags, commonDeps := d.dexCommonFlags(ctx, minSdkVersion)
useR8 := d.effectiveOptimizeEnabled() useR8 := d.effectiveOptimizeEnabled()
if useR8 { if useR8 {
@@ -298,6 +308,7 @@ func (d *dexer) compileDex(ctx android.ModuleContext, flags javaBuilderFlags, mi
proguardUsageZip := android.PathForModuleOut(ctx, "proguard_usage.zip") proguardUsageZip := android.PathForModuleOut(ctx, "proguard_usage.zip")
d.proguardUsageZip = android.OptionalPathForPath(proguardUsageZip) d.proguardUsageZip = android.OptionalPathForPath(proguardUsageZip)
r8Flags, r8Deps := d.r8Flags(ctx, flags) r8Flags, r8Deps := d.r8Flags(ctx, flags)
r8Deps = append(r8Deps, commonDeps...)
rule := r8 rule := r8
args := map[string]string{ args := map[string]string{
"r8Flags": strings.Join(append(commonFlags, r8Flags...), " "), "r8Flags": strings.Join(append(commonFlags, r8Flags...), " "),
@@ -324,6 +335,7 @@ func (d *dexer) compileDex(ctx android.ModuleContext, flags javaBuilderFlags, mi
}) })
} else { } else {
d8Flags, d8Deps := d8Flags(flags) d8Flags, d8Deps := d8Flags(flags)
d8Deps = append(d8Deps, commonDeps...)
rule := d8 rule := d8
if ctx.Config().UseRBE() && ctx.Config().IsEnvTrue("RBE_D8") { if ctx.Config().UseRBE() && ctx.Config().IsEnvTrue("RBE_D8") {
rule = d8RE rule = d8RE