Merge "CFI Versionscript changes in bp2build" am: 197f4306d5

Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2597866

Change-Id: I03f28f05cd15b0bc976c0566427a1b2442f3ea2f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
Trevor Radcliffe
2023-05-19 20:52:05 +00:00
committed by Automerger Merge Worker
4 changed files with 17 additions and 2 deletions

View File

@@ -222,6 +222,7 @@ func TestCcBinaryVersionScriptAndDynamicList(t *testing.T) {
"-Wl,--version-script,$(location vs)",
"-Wl,--dynamic-list,$(location dynamic.list)",
]`,
"features": `["android_cfi_exports_map"]`,
},
},
},
@@ -249,6 +250,7 @@ func TestCcBinaryLdflagsSplitBySpaceExceptSoongAdded(t *testing.T) {
"version_script",
"dynamic.list",
]`,
"features": `["android_cfi_exports_map"]`,
"linkopts": `[
"--nospace_flag",
"-z",

View File

@@ -901,6 +901,7 @@ cc_library {
"-Wl,--dynamic-list,$(location dynamic.list)",
]`,
"srcs": `["a.cpp"]`,
"features": `["android_cfi_exports_map"]`,
}),
},
)
@@ -958,6 +959,11 @@ cc_library {
"//conditions:default": [],
})`,
"srcs": `["a.cpp"]`,
"features": `select({
"//build/bazel/platforms/arch:arm": ["android_cfi_exports_map"],
"//build/bazel/platforms/arch:arm64": ["android_cfi_exports_map"],
"//conditions:default": [],
})`,
}),
},
)
@@ -985,12 +991,15 @@ cc_library {
}
`,
ExpectedBazelTargets: []string{
MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{}),
MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
"features": `["android_cfi_exports_map"]`,
}),
MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
"additional_linker_inputs": `[
"version_script",
"dynamic.list",
]`,
"features": `["android_cfi_exports_map"]`,
"linkopts": `[
"--nospace_flag",
"-z",

View File

@@ -362,6 +362,7 @@ cc_library_shared {
"-Wl,--version-script,$(location version_script)",
"-Wl,--dynamic-list,$(location dynamic.list)",
]`,
"features": `["android_cfi_exports_map"]`,
}),
},
})
@@ -398,6 +399,7 @@ cc_library_shared {
"-Wl,--version-script,$(location version_script)",
"-Wl,--dynamic-list,$(location dynamic.list)",
]`,
"features": `["android_cfi_exports_map"]`,
}),
},
})
@@ -913,6 +915,7 @@ func TestCCLibraryFlagSpaceSplitting(t *testing.T) {
"header.h",
]`,
"linkopts": `["-Wl,--version-script,$(location version_script)"]`,
"features": `["android_cfi_exports_map"]`,
}),
},
})

View File

@@ -1257,6 +1257,7 @@ func (la *linkerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversion
label := android.BazelLabelForModuleSrcSingle(ctx, *props.Version_script)
additionalLinkerInputs.Add(&label)
linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--version-script,$(location %s)", label.Label))
axisFeatures = append(axisFeatures, "android_cfi_exports_map")
}
if props.Dynamic_list != nil {