From 763710ca78f30666cfab443d0d6db24167aa5e25 Mon Sep 17 00:00:00 2001 From: Cole Faust Date: Tue, 21 Nov 2023 14:04:52 -0800 Subject: [PATCH] Sandbox vndk_abi_dump_zip Sandboxing it generates this diff in it's output zip file: 1,4c1,2 < Archive: out_not_sandboxed/soong/.intermediates/prebuilts/abi-dumps/vndk/vndk_abi_dump_zip/gen/vndk_abi_dump.zip < Zip file size: 319522663 bytes, number of entries: 7462 < -rw-r--r-- 2.0 unx 1055 bl 612 defN 08-Jan-01 00:00 Android.bp < -rw-r--r-- 2.0 unx 143 bl 99 defN 08-Jan-01 00:00 OWNERS --- > Archive: out/soong/.intermediates/prebuilts/abi-dumps/vndk/vndk_abi_dump_zip/gen/vndk_abi_dump.zip > Zip file size: 319519888 bytes, number of entries: 7454 6810d6807 < -rw-r--r-- 2.0 unx 722 bl 142 defN 08-Jan-01 00:00 34/64/arm/source-based/config.json 6926d6922 < -rw-r--r-- 2.0 unx 722 bl 142 defN 08-Jan-01 00:00 34/64/arm64/source-based/config.json 7042d7037 < -rw-r--r-- 2.0 unx 722 bl 142 defN 08-Jan-01 00:00 34/64/arm_arm64/source-based/config.json 7158d7152 < -rw-r--r-- 2.0 unx 722 bl 142 defN 08-Jan-01 00:00 34/64/x86/source-based/config.json 7274d7267 < -rw-r--r-- 2.0 unx 722 bl 142 defN 08-Jan-01 00:00 34/64/x86_64/source-based/config.json 7390d7382 < -rw-r--r-- 2.0 unx 722 bl 142 defN 08-Jan-01 00:00 34/64/x86_x86_64/source-based/config.json 7465c7457 < 7462 files, 5412913325 bytes uncompressed, 317891705 bytes compressed: 94.1% --- > 7454 files, 5412907795 bytes uncompressed, 317890142 bytes compressed: 94.1% So sandboxing removes some files from the zip. It appears that the intention of this zip file was to include a bunch of .lsdump files, and these files that were removed were extraneous. Bug: 307824623 Test: ./build/soong/tests/genrule_sandbox_test.py vndk_abi_dump_zip Change-Id: I15df4a4b54df362c30e2b231f6fed586cf0a267f --- genrule/allowlists.go | 1 - 1 file changed, 1 deletion(-) diff --git a/genrule/allowlists.go b/genrule/allowlists.go index 28d3d5497..53a69b412 100644 --- a/genrule/allowlists.go +++ b/genrule/allowlists.go @@ -69,7 +69,6 @@ var ( "swiftshader_spvtools_update_build_version", "ue_unittest_erofs_imgs", "vm-tests-tf-lib", - "vndk_abi_dump_zip", // go/keep-sorted end }