StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "RBE should not copy source file back to local" am: 7686708a43 am: e1d5c9fdd0 am: bca91a4a30

Browse Source 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1814116

Change-Id: I241245a63e4b94e206c9cddbc3442f89b8635223
This commit is contained in:
Chih-hung Hsieh
2021-09-01 21:25:15 +00:00
committed by Automerger Merge Worker
parent 41a4222301 bca91a4a30
commit 861bdbd093
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cc/builder.go
View File

@@ -205,10 +205,12 @@ var (
Labels: map[string]string{"type": "lint", "tool": "clang-tidy", "lang": "cpp"},
ExecStrategy: "${config.REClangTidyExecStrategy}",
Inputs: []string{"$in"},
// OutputFile here is $in for remote-execution since its possible that
// clang-tidy modifies the given input file itself and $out refers to the
// ".tidy" file generated for ninja-dependency reasons.
OutputFiles: []string{"$in"},
// Although clang-tidy has an option to "fix" source files, that feature is hardly useable
// under parallel compilation and RBE. So we assume no OutputFiles here.
// The clang-tidy fix option is best run locally in single thread.
// Copying source file back to local caused two problems:
// (1) New timestamps trigger clang and clang-tidy compilations again.
// (2) Changing source files caused concurrent clang or clang-tidy jobs to crash.
Platform: map[string]string{remoteexec.PoolKey: "${config.REClangTidyPool}"},
}, []string{"cFlags", "tidyFlags"}, []string{})