StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Do not modify input in-place" into udc-dev am: 4f0c490ac9

Browse Source 
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/soong/+/23374037

Change-Id: I5049264e5e1976952f87e5dcd58ee1db32489623
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
Yu Liu
2023-05-24 00:16:06 +00:00
committed by Automerger Merge Worker
parent 7b67d8c8e1 4f0c490ac9
commit 86446d4c46
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
android/util.go
View File

@@ -280,6 +280,8 @@ func RemoveFromList(s string, list []string) (bool, []string) {
// FirstUniqueStrings returns all unique elements of a slice of strings, keeping the first copy of // FirstUniqueStrings returns all unique elements of a slice of strings, keeping the first copy of
// each. It modifies the slice contents in place, and returns a subslice of the original slice. // each. It modifies the slice contents in place, and returns a subslice of the original slice.
func FirstUniqueStrings(list []string) []string { func FirstUniqueStrings(list []string) []string {
// Do not moodify the input in-place, operate on a copy instead.
list = CopyOf(list)
// 128 was chosen based on BenchmarkFirstUniqueStrings results. // 128 was chosen based on BenchmarkFirstUniqueStrings results.
if len(list) > 128 { if len(list) > 128 {
return firstUniqueStringsMap(list) return firstUniqueStringsMap(list)
@@ -336,6 +338,7 @@ func LastUniqueStrings(list []string) []string {
// SortedUniqueStrings returns what the name says // SortedUniqueStrings returns what the name says
func SortedUniqueStrings(list []string) []string { func SortedUniqueStrings(list []string) []string {
// FirstUniqueStrings creates a copy of `list`, so the input remains untouched.
unique := FirstUniqueStrings(list) unique := FirstUniqueStrings(list)
sort.Strings(unique) sort.Strings(unique)
return unique return unique