StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add some friendly error messages for java_sdk_library.

Browse Source 
The stubs will always fail to build without at least these
three arguments. Give a clear error message when this happens
instead of failing further into the build.

Bug: 77575606
Test: make <x>.stubs for sdk_library "x" without these args
Change-Id: If3142ecc73d6428f7e3120788f8de64d56a777ad
This commit is contained in:
Anton Hansson
2018-04-25 11:56:13 +01:00
parent b6ffb625eb
commit 8959e149b7
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
java/sdk_library.go
View File

@@ -485,6 +485,13 @@ func javaSdkLibraries(config android.Config) *[]string {
// once for public API level and once for system API level // once for public API level and once for system API level
func sdkLibraryMutator(mctx android.TopDownMutatorContext) { func sdkLibraryMutator(mctx android.TopDownMutatorContext) {
if module, ok := mctx.Module().(*sdkLibrary); ok { if module, ok := mctx.Module().(*sdkLibrary); ok {
if module.properties.Srcs == nil {
mctx.PropertyErrorf("srcs", "java_sdk_library must specify srcs")
}
if module.properties.Api_packages == nil {
mctx.PropertyErrorf("api_packages", "java_sdk_library must specify api_packages")
}
// for public API stubs // for public API stubs
module.createStubsLibrary(mctx, apiScopePublic) module.createStubsLibrary(mctx, apiScopePublic)
module.createDocs(mctx, apiScopePublic) module.createDocs(mctx, apiScopePublic)