StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix symlinks to system libs for flattened apex"

Browse Source
This commit is contained in:
Treehugger Robot
2020-01-24 08:32:05 +00:00
committed by Gerrit Code Review
parent 84f71af41c 75de261056
commit 8c94763bf7
1 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apex/androidmk.go
View File

@@ -63,7 +63,6 @@ func (a *apexBundle) androidMkForFiles(w io.Writer, apexName, moduleDir string)
postInstallCommands = append(postInstallCommands, mkdirCmd, linkCmd) postInstallCommands = append(postInstallCommands, mkdirCmd, linkCmd)
} }
} }
postInstallCommands = append(postInstallCommands, a.compatSymlinks...)
for _, fi := range a.filesInfo { for _, fi := range a.filesInfo {
if cc, ok := fi.module.(*cc.Module); ok && cc.Properties.HideFromMake { if cc, ok := fi.module.(*cc.Module); ok && cc.Properties.HideFromMake {
@@ -178,7 +177,8 @@ func (a *apexBundle) androidMkForFiles(w io.Writer, apexName, moduleDir string)
fmt.Fprintln(w, "include $(BUILD_SYSTEM)/soong_cc_prebuilt.mk") fmt.Fprintln(w, "include $(BUILD_SYSTEM)/soong_cc_prebuilt.mk")
} else { } else {
fmt.Fprintln(w, "LOCAL_MODULE_STEM :=", fi.builtFile.Base()) fmt.Fprintln(w, "LOCAL_MODULE_STEM :=", fi.builtFile.Base())
if a.primaryApexType && fi.builtFile == a.manifestPbOut { if fi.builtFile == a.manifestPbOut {
if a.primaryApexType {
// Make apex_manifest.pb module for this APEX to override all other // Make apex_manifest.pb module for this APEX to override all other
// modules in the APEXes being overridden by this APEX // modules in the APEXes being overridden by this APEX
var patterns []string var patterns []string
@@ -187,8 +187,12 @@ func (a *apexBundle) androidMkForFiles(w io.Writer, apexName, moduleDir string)
} }
fmt.Fprintln(w, "LOCAL_OVERRIDES_MODULES :=", strings.Join(patterns, " ")) fmt.Fprintln(w, "LOCAL_OVERRIDES_MODULES :=", strings.Join(patterns, " "))
if apexType == flattenedApex && len(postInstallCommands) > 0 { if apexType == flattenedApex && len(a.compatSymlinks) > 0 {
// For flattened apexes, compat symlinks are attached to apex_manifest.json which is guaranteed for every apex // For flattened apexes, compat symlinks are attached to apex_manifest.json which is guaranteed for every apex
postInstallCommands = append(postInstallCommands, a.compatSymlinks...)
}
}
if len(postInstallCommands) > 0 {
fmt.Fprintln(w, "LOCAL_POST_INSTALL_CMD :=", strings.Join(postInstallCommands, " && ")) fmt.Fprintln(w, "LOCAL_POST_INSTALL_CMD :=", strings.Join(postInstallCommands, " && "))
} }
} }