StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix finding next symbol when multiple symbols have the same address"

Browse Source
This commit is contained in:
Treehugger Robot
2018-03-01 05:15:42 +00:00
committed by Gerrit Code Review
parent 3bb14200e2 dfce764476
commit 8d43b7cf81
2 changed files with 52 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
cmd/symbol_inject/macho.go
View File

@@ -38,37 +38,33 @@ func findMachoSymbol(r io.ReaderAt, symbolName string) (uint64, uint64, error) {
return symbols[i].Value < symbols[j].Value return symbols[i].Value < symbols[j].Value
}) })
for i, symbol := range symbols { for _, symbol := range symbols {
if symbol.Sect == 0 { if symbol.Name == symbolName && symbol.Sect != 0 {
continue // Find the next symbol in the same section with a higher address
} n := sort.Search(len(symbols), func(i int) bool {
if symbol.Name == symbolName { return symbols[i].Sect == symbol.Sect &&
var nextSymbol *macho.Symbol symbols[i].Value > symbol.Value
if i+1 < len(symbols) { })
nextSymbol = &symbols[i+1]
}
return calculateMachoSymbolOffset(machoFile, symbol, nextSymbol)
}
}
return maxUint64, maxUint64, fmt.Errorf("symbol not found") section := machoFile.Sections[symbol.Sect-1]
}
func calculateMachoSymbolOffset(file *macho.File, symbol macho.Symbol, nextSymbol *macho.Symbol) (uint64, uint64, error) {
section := file.Sections[symbol.Sect-1]
var end uint64 var end uint64
if nextSymbol != nil && nextSymbol.Sect != symbol.Sect { if n < len(symbols) {
nextSymbol = nil end = symbols[n].Value
}
if nextSymbol != nil {
end = nextSymbol.Value
} else { } else {
end = section.Addr + section.Size end = section.Addr + section.Size
} }
if end <= symbol.Value && end > symbol.Value+4096 {
return maxUint64, maxUint64, fmt.Errorf("symbol end address does not seem valid, %x:%x", symbol.Value, end)
}
size := end - symbol.Value - 1 size := end - symbol.Value - 1
offset := uint64(section.Offset) + (symbol.Value - section.Addr) offset := uint64(section.Offset) + (symbol.Value - section.Addr)
return offset, size, nil return offset, size, nil
} }
}
return maxUint64, maxUint64, fmt.Errorf("symbol not found")
}

44
cmd/symbol_inject/pe.go
View File

@@ -32,41 +32,41 @@ func findPESymbol(r io.ReaderAt, symbolName string) (uint64, uint64, error) {
symbolName = "_" + symbolName symbolName = "_" + symbolName
} }
sort.Slice(peFile.Symbols, func(i, j int) bool { symbols := peFile.Symbols
if peFile.Symbols[i].SectionNumber != peFile.Symbols[j].SectionNumber { sort.Slice(symbols, func(i, j int) bool {
return peFile.Symbols[i].SectionNumber < peFile.Symbols[j].SectionNumber if symbols[i].SectionNumber != symbols[j].SectionNumber {
return symbols[i].SectionNumber < symbols[j].SectionNumber
} }
return peFile.Symbols[i].Value < peFile.Symbols[j].Value return symbols[i].Value < symbols[j].Value
}) })
for i, symbol := range peFile.Symbols { for _, symbol := range symbols {
if symbol.Name == symbolName { if symbol.Name == symbolName {
var nextSymbol *pe.Symbol // Find the next symbol (n the same section with a higher address
if i+1 < len(peFile.Symbols) { n := sort.Search(len(symbols), func(i int) bool {
nextSymbol = peFile.Symbols[i+1] return symbols[i].SectionNumber == symbol.SectionNumber &&
} symbols[i].Value > symbol.Value
return calculatePESymbolOffset(peFile, symbol, nextSymbol) })
}
}
return maxUint64, maxUint64, fmt.Errorf("symbol not found") section := peFile.Sections[symbol.SectionNumber-1]
}
func calculatePESymbolOffset(file *pe.File, symbol *pe.Symbol, nextSymbol *pe.Symbol) (uint64, uint64, error) {
section := file.Sections[symbol.SectionNumber-1]
var end uint32 var end uint32
if nextSymbol != nil && nextSymbol.SectionNumber != symbol.SectionNumber { if n < len(symbols) {
nextSymbol = nil end = symbols[n].Value
}
if nextSymbol != nil {
end = nextSymbol.Value
} else { } else {
end = section.Size end = section.Size
} }
if end <= symbol.Value && end > symbol.Value+4096 {
return maxUint64, maxUint64, fmt.Errorf("symbol end address does not seem valid, %x:%x", symbol.Value, end)
}
size := end - symbol.Value - 1 size := end - symbol.Value - 1
offset := section.Offset + symbol.Value offset := section.Offset + symbol.Value
return uint64(offset), uint64(size), nil return uint64(offset), uint64(size), nil
} }
}
return maxUint64, maxUint64, fmt.Errorf("symbol not found")
}