From 96ff7227a03d3780ff0f773204e65871262cb5bd Mon Sep 17 00:00:00 2001 From: Usta Shrestha Date: Tue, 9 Aug 2022 17:41:15 -0400 Subject: [PATCH] soong_ui to reject "showcommands" deprecated flag that simply adds 5s to a build the `ctx.Done()` signal handling is unnecessary because of clean-up hooks already in place Test: m libc Bug: N/A Change-Id: Ica12d727264af1e61e97393bc8cbeba9f78cbc83 --- cmd/soong_ui/main.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/cmd/soong_ui/main.go b/cmd/soong_ui/main.go index 2770094e3..3d18849b9 100644 --- a/cmd/soong_ui/main.go +++ b/cmd/soong_ui/main.go @@ -489,11 +489,7 @@ func runMake(ctx build.Context, config build.Config, _ []string, logsDir string) fmt.Fprintln(writer, "!") fmt.Fprintln(writer, "! Older versions are saved in verbose.log.#.gz files") fmt.Fprintln(writer, "") - select { - case <-time.After(5 * time.Second): - case <-ctx.Done(): - return - } + ctx.Fatal("done") } if _, ok := config.Environment().Get("ONE_SHOT_MAKEFILE"); ok {