Merge "Generate .srcjar for prebuilt_stubs_sources" am: e2bc36f12c am: 954e23e3e0 am: a8d9e2ecdd

Change-Id: Ica5b34271f7c1e7854f4cc7847e653851552ef26
This commit is contained in:
Automerger Merge Worker
2019-12-23 14:02:03 +00:00
5 changed files with 102 additions and 37 deletions

View File

@@ -118,6 +118,9 @@ type Path interface {
type WritablePath interface {
Path
// return the path to the build directory.
buildDir() string
// the writablePath method doesn't directly do anything,
// but it allows a struct to distinguish between whether or not it implements the WritablePath interface
writablePath()
@@ -848,7 +851,12 @@ func (p OutputPath) WithoutRel() OutputPath {
return p
}
func (p OutputPath) buildDir() string {
return p.config.buildDir
}
var _ Path = OutputPath{}
var _ WritablePath = OutputPath{}
// PathForOutput joins the provided paths and returns an OutputPath that is
// validated to not escape the build dir.
@@ -1151,6 +1159,13 @@ type InstallPath struct {
baseDir string // "../" for Make paths to convert "out/soong" to "out", "" for Soong paths
}
func (p InstallPath) buildDir() string {
return p.config.buildDir
}
var _ Path = InstallPath{}
var _ WritablePath = InstallPath{}
func (p InstallPath) writablePath() {}
func (p InstallPath) String() string {
@@ -1302,6 +1317,10 @@ type PhonyPath struct {
func (p PhonyPath) writablePath() {}
func (p PhonyPath) buildDir() string {
return p.config.buildDir
}
var _ Path = PhonyPath{}
var _ WritablePath = PhonyPath{}

View File

@@ -16,6 +16,7 @@ package android
import (
"fmt"
"path/filepath"
"regexp"
"strings"
"testing"
@@ -411,3 +412,33 @@ func AndroidMkDataForTest(t *testing.T, config Config, bpPath string, mod bluepr
data.fillInData(config, bpPath, mod)
return data
}
// Normalize the path for testing.
//
// If the path is relative to the build directory then return the relative path
// to avoid tests having to deal with the dynamically generated build directory.
//
// Otherwise, return the supplied path as it is almost certainly a source path
// that is relative to the root of the source tree.
//
// The build and source paths should be distinguishable based on their contents.
func NormalizePathForTesting(path Path) string {
p := path.String()
if w, ok := path.(WritablePath); ok {
rel, err := filepath.Rel(w.buildDir(), p)
if err != nil {
panic(err)
}
return rel
}
return p
}
func NormalizePathsForTesting(paths Paths) []string {
var result []string
for _, path := range paths {
relative := NormalizePathForTesting(path)
result = append(result, relative)
}
return result
}