From ea28f4cae7c1a4c9dcaa4d1b9d644581553b649f Mon Sep 17 00:00:00 2001 From: Junwei Wang Date: Thu, 19 Aug 2021 08:10:05 +0000 Subject: [PATCH] Revert "Apply pylint to cc/symbolfile" This reverts commit 73de70264afbaa8fbf731fe6f8443cee4a109181. Reason for revert: Broken build 7651218 on aosp-master on aosp_x86_64-userdebug -- b/197190129 Change-Id: I18387e5d2765fecb292127d09e3bbe7cf19b5efd --- cc/symbolfile/__init__.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cc/symbolfile/__init__.py b/cc/symbolfile/__init__.py index f8d18414c..31c444385 100644 --- a/cc/symbolfile/__init__.py +++ b/cc/symbolfile/__init__.py @@ -329,7 +329,7 @@ class SymbolFileParser: def parse(self) -> List[Version]: """Parses the symbol file and returns a list of Version objects.""" versions = [] - while self.next_line(): + while self.next_line() != '': assert self.current_line is not None if '{' in self.current_line: versions.append(self.parse_version()) @@ -376,7 +376,7 @@ class SymbolFileParser: symbols: List[Symbol] = [] global_scope = True cpp_symbols = False - while self.next_line(): + while self.next_line() != '': if '}' in self.current_line: # Line is something like '} BASE; # tags'. Both base and tags # are optional here. @@ -428,11 +428,11 @@ class SymbolFileParser: A return value of '' indicates EOF. """ line = self.input_file.readline() - while not line.strip() or line.strip().startswith('#'): + while line.strip() == '' or line.strip().startswith('#'): line = self.input_file.readline() # We want to skip empty lines, but '' indicates EOF. - if not line: + if line == '': break self.current_line = line return self.current_line