From ffdeacb30967402c76c22e317996b9908aaff2c0 Mon Sep 17 00:00:00 2001 From: Alix Date: Mon, 20 Mar 2023 18:22:45 +0000 Subject: [PATCH] Add TODO comment for min_sdk_verison in android_app Bp2Build Test: NA added a comment Bug: 274474008 Change-Id: I1c02c2877e638589730a7b2b565382c010dfe084 --- java/app.go | 1 + 1 file changed, 1 insertion(+) diff --git a/java/app.go b/java/app.go index 1a324bfeb..8b54bc8cd 100755 --- a/java/app.go +++ b/java/app.go @@ -1522,6 +1522,7 @@ func (a *AndroidApp) ConvertWithBp2build(ctx android.TopDownMutatorContext) { certificate, certificateName := android.BazelStringOrLabelFromProp(ctx, a.overridableAppProperties.Certificate) manifestValues := &manifestValueAttribute{} + // TODO(b/274474008 ): Directly convert deviceProperties.Min_sdk_version in bp2build // MinSdkVersion(ctx) calls SdkVersion(ctx) if no value for min_sdk_version is set minSdkSpec := a.MinSdkVersion(ctx) if !minSdkSpec.ApiLevel.IsPreview() && minSdkSpec.Valid() {