Merge "bp2build/queryview: codegen control sequences literally."

2021-03-30 21:57:09 +00:00
parent ff1c8c49c0 58a12b8bae
commit a5dcb03450
2 changed files with 23 additions and 0 deletions
--- a/bp2build/build_conversion.go
+++ b/bp2build/build_conversion.go
@@ -568,6 +568,13 @@ func isZero(value reflect.Value) bool {

 func escapeString(s string) string {
 	s = strings.ReplaceAll(s, "\\", "\\\\")
+
+	// b/184026959: Reverse the application of some common control sequences.
+	// These must be generated literally in the BUILD file.
+	s = strings.ReplaceAll(s, "\t", "\\t")
+	s = strings.ReplaceAll(s, "\n", "\\n")
+	s = strings.ReplaceAll(s, "\r", "\\r")
+
 	return strings.ReplaceAll(s, "\"", "\\\"")
 }