From ed62b9cc2a24dd0874f8689902bad759a722497a Mon Sep 17 00:00:00 2001 From: Paul Duffin Date: Tue, 16 Jun 2020 16:12:50 +0100 Subject: [PATCH] Differentiate sdk snapshot include dir by os type Test: m nothing Change-Id: Ide032aa64bb1fee69969c5e007bee6643d475309 --- cc/library_sdk_member.go | 2 +- sdk/cc_sdk_test.go | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/cc/library_sdk_member.go b/cc/library_sdk_member.go index 9c543990f..4b9eb302c 100644 --- a/cc/library_sdk_member.go +++ b/cc/library_sdk_member.go @@ -234,7 +234,7 @@ func addPossiblyArchSpecificProperties(sdkModuleContext android.ModuleContext, b for _, propertyInfo := range includeDirProperties { // Calculate the base directory in the snapshot into which the files will be copied. // lib.ArchType is "" for common properties. - targetDir := filepath.Join(libInfo.archType, propertyInfo.snapshotDir) + targetDir := filepath.Join(libInfo.OsPrefix(), libInfo.archType, propertyInfo.snapshotDir) propertyName := propertyInfo.propertyName diff --git a/sdk/cc_sdk_test.go b/sdk/cc_sdk_test.go index c59cd3095..b168cd036 100644 --- a/sdk/cc_sdk_test.go +++ b/sdk/cc_sdk_test.go @@ -1614,13 +1614,13 @@ cc_prebuilt_library_headers { sdk_member_name: "mynativeheaders", host_supported: true, stl: "none", - export_system_include_dirs: ["include/include"], + export_system_include_dirs: ["common_os/include/include"], target: { android: { - export_include_dirs: ["include/include-android"], + export_include_dirs: ["android/include/include-android"], }, linux_glibc: { - export_include_dirs: ["include/include-host"], + export_include_dirs: ["linux_glibc/include/include-host"], }, }, } @@ -1630,13 +1630,13 @@ cc_prebuilt_library_headers { prefer: false, host_supported: true, stl: "none", - export_system_include_dirs: ["include/include"], + export_system_include_dirs: ["common_os/include/include"], target: { android: { - export_include_dirs: ["include/include-android"], + export_include_dirs: ["android/include/include-android"], }, linux_glibc: { - export_include_dirs: ["include/include-host"], + export_include_dirs: ["linux_glibc/include/include-host"], }, }, } @@ -1648,9 +1648,9 @@ sdk_snapshot { } `), checkAllCopyRules(` -include/Test.h -> include/include/Test.h -include-android/AndroidTest.h -> include/include-android/AndroidTest.h -include-host/HostTest.h -> include/include-host/HostTest.h +include/Test.h -> common_os/include/include/Test.h +include-android/AndroidTest.h -> android/include/include-android/AndroidTest.h +include-host/HostTest.h -> linux_glibc/include/include-host/HostTest.h `), ) }